feat: Image add PreviewGroup component to support multiple images preview #28069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afc163
reviewed
Nov 30, 2020
| @@ -11,4 +16,6 @@ const Image: React.FC<ImageProps> = ({ prefixCls: customizePrefixCls, ...otherPr | |||
|
|
|||
| export { ImageProps }; | |||
|
|
|||
| Image.PreviewGroup = PreviewGroup; | |||
There was a problem hiding this comment.
Image.PreviewGroup 还是 Image.Group 好一点？
There was a problem hiding this comment.
There was a problem hiding this comment.
我比较倾向于先保留 Group，用 PreviewGroup。
|
|
|
顶部的操作栏在刚打开出现动画时有点别扭，应该在 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d7a9f99:
|
这个之后再调就行了。这个 PR 可以先合 |
zombieJ
approved these changes
Nov 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self Check before Merge
View rendered components/image/demo/previewGroup.md