Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hook modal not trigger onCancel #28063

Merged
merged 1 commit into from
Nov 30, 2020

Conversation

JuniorTour
Copy link
Contributor

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

Fix: #27136

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English fix: hook modal not trigger onCancel
🇨🇳 Chinese 修复 hook modal 没有触发 onCancel 的问题

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Nov 29, 2020

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 59a33b0:

Sandbox Source
antd reproduction template Configuration
antd reproduction template (forked) Issue #27136

@codecov
Copy link

codecov bot commented Nov 29, 2020

Codecov Report

Merging #28063 (59a33b0) into master (4f811cb) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #28063   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          389       389           
  Lines         7339      7342    +3     
  Branches      2045      2046    +1     
=========================================
+ Hits          7339      7342    +3     
Impacted Files Coverage Δ
components/modal/useModal/HookModal.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f811cb...59a33b0. Read the comment docs.

@afc163 afc163 requested a review from zombieJ November 30, 2020 02:52
@zombieJ zombieJ merged commit e063a3a into ant-design:master Nov 30, 2020
@zombieJ zombieJ mentioned this pull request Nov 30, 2020
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants