Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修改beforeUpload ts定义 #27946

Merged
merged 1 commit into from
Nov 23, 2020

Conversation

bingling0084
Copy link
Contributor

@bingling0084 bingling0084 commented Nov 23, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

  1. The doc shows that beforeUpload supports resolve File or Blob, but the actual definition of ts is beforeUpload?: (file: RcFile, FileList: RcFile[]) => boolean | PromiseLike<void>, which does not match description.
  2. image
  3. Fix the ts definition of beforeUpload to be consistent with the instructions.

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Nov 23, 2020

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 716841e:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Nov 23, 2020

Codecov Report

Merging #27946 (716841e) into master (87da555) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #27946   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          389       389           
  Lines         7335      7335           
  Branches      2085      2095   +10     
=========================================
  Hits          7335      7335           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87da555...716841e. Read the comment docs.

@afc163 afc163 merged commit e0c19e4 into ant-design:master Nov 23, 2020
@zombieJ zombieJ mentioned this pull request Nov 27, 2020
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants