Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CarouselRef type #27935

Merged
merged 2 commits into from
Nov 23, 2020
Merged

CarouselRef type #27935

merged 2 commits into from
Nov 23, 2020

Conversation

ocassio
Copy link
Contributor

@ocassio ocassio commented Nov 22, 2020 •
edited by afc163
Loading

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #27932

💡 Background and solution

After refactoring, Carousel ref definition has been typed as unknown, which lead to inconvenience in carousel reference usage in TypeScript projects.

These changes provides a separate CarouselRef type which can be used as follows:

const carouselRef = useRef<CarouselRef>(null);
const handleNext = () => carouselRef.current?.next();

📝 Changelog

Language Changelog
🇺🇸 English Provided a separate type definition for Carousel reference
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Nov 22, 2020 •
edited
Loading

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9156c57:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Nov 22, 2020 •
edited
Loading

Codecov Report

Merging #27935 (9156c57) into master (87da555) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #27935   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          389       389           
  Lines         7335      7335           
  Branches      2085      2095   +10     
=========================================
  Hits          7335      7335
Impacted Files Coverage Δ
components/carousel/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87da555...9156c57. Read the comment docs.

@afc163 afc163 merged commit 66f425c into ant-design:master Nov 23, 2020
@zombieJ zombieJ mentioned this pull request Nov 27, 2020
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hengkx hengkx hengkx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Methods are missing in Carousel type declaration
4 participants
@ocassio @ant-design-bot @hengkx @afc163