Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support closeIcon of Modal.method #27909

Merged
merged 9 commits into from
Nov 21, 2020
Merged

feat: Support closeIcon of Modal.method #27909

merged 9 commits into from
Nov 21, 2020

Conversation

MrHeer
Copy link
Contributor

@MrHeer MrHeer commented Nov 20, 2020 •
edited
Loading

close #27900

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#27900

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Support closable and closeIcon api for Modal.method
🇨🇳 Chinese Modal.method 支持 closable 和 closeIcon

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/modal/index.en-US.md
View rendered components/modal/index.zh-CN.md

@pr-triage pr-triage bot added the PR: draft label Nov 20, 2020
@ant-design-bot
Copy link
Contributor

ant-design-bot commented Nov 20, 2020 •
edited
Loading

@github-actions
Copy link
Contributor

github-actions bot commented Nov 20, 2020 •
edited
Loading

Size Change: +46 B (0%)

Total Size: 789 kB

Filename Size Change
./dist/antd-with-locales.min.js 313 kB +30 B (0%)
./dist/antd.compact.min.css 66.2 kB -4 B (0%)
./dist/antd.dark.min.css 67.5 kB -7 B (0%)
./dist/antd.min.css 66.2 kB -4 B (0%)
./dist/antd.min.js 276 kB +31 B (0%)

compressed-size-action

@MrHeer MrHeer linked an issue Nov 20, 2020 that may be closed by this pull request
Modal confirm自定义关闭图标 #27900
Closed
1 task
@MrHeer MrHeer removed the PR: draft label Nov 21, 2020
@MrHeer MrHeer marked this pull request as ready for review November 21, 2020 03:22
@MrHeer MrHeer requested a review from afc163 November 21, 2020 03:22
@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 21, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c7b015a:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Nov 21, 2020 •
edited
Loading

Codecov Report

Merging #27909 (1ecb4ec) into feature (093a458) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           feature    #27909   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          392       392           
  Lines         7322      7323    +1     
  Branches      2093      2094    +1     
=========================================
+ Hits          7322      7323    +1
Impacted Files Coverage Δ
components/modal/Modal.tsx 100.00% <ø> (ø)
components/modal/ConfirmDialog.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 093a458...c7b015a. Read the comment docs.

@MrHeer
Copy link
Contributor Author

MrHeer commented Nov 21, 2020

@afc163 你看看这样是不是好点

@afc163 afc163 merged commit 0ca5326 into feature Nov 21, 2020
@afc163 afc163 deleted the feat/close-icon-for-Modal.method branch November 21, 2020 13:13
@zombieJ zombieJ mentioned this pull request Nov 30, 2020
Merged
15 tasks
@zkwolf zkwolf mentioned this pull request Feb 4, 2021
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afc163 afc163 afc163 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modal confirm自定义关闭图标
3 participants
@MrHeer @ant-design-bot @afc163