Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Spin render 0 #27839

Merged
merged 1 commit into from
Nov 18, 2020
Merged

fix: Spin render 0 #27839

merged 1 commit into from
Nov 18, 2020

Conversation

liuchao233
Copy link
Contributor

@liuchao233 liuchao233 commented Nov 17, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #27826

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English fix bug: Spin can't render children 0
🇨🇳 Chinese 修复Spin 组件不能渲染 0 的问题

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Nov 17, 2020

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 82f0ad6:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Nov 17, 2020

Codecov Report

Merging #27839 (82f0ad6) into master (1a8bb04) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #27839   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          389       389           
  Lines         7374      7374           
  Branches      2043      2086   +43     
=========================================
  Hits          7374      7374           
Impacted Files Coverage Δ
components/spin/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a8bb04...82f0ad6. Read the comment docs.

@afc163 afc163 merged commit c04e510 into ant-design:master Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spin组件不支持children为0的情况
4 participants