Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Modal.confirm locale missing #27797

Merged
merged 3 commits into from
Nov 16, 2020
Merged

fix: Modal.confirm locale missing #27797

merged 3 commits into from
Nov 16, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Nov 16, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #27787
close #27597
close #27720
close #27662
close #27578

💡 Background and solution

#27376 里加了一层 ConfigProvider 把事情搞坏了。

📝 Changelog

Language Changelog
🇺🇸 English Fix Modal.confirm locale missing after close it.
🇨🇳 Chinese 修复 Modal.confirm 关闭时国际化丢失的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Nov 16, 2020 •
edited
Loading

@github-actions
Copy link
Contributor

github-actions bot commented Nov 16, 2020 •
edited
Loading

Size Change: -5 B (0%)

Total Size: 789 kB

Filename Size Change
./dist/antd-with-locales.min.js 312 kB -3 B (0%)
./dist/antd.min.js 276 kB -2 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd.compact.min.css 66.4 kB 0 B
./dist/antd.dark.min.css 67.8 kB 0 B
./dist/antd.min.css 66.5 kB 0 B

compressed-size-action

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 16, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 272dc6b:

Sandbox Source
antd reproduction template Configuration
antd reproduction template (forked) Issue #27662

@codecov
Copy link

codecov bot commented Nov 16, 2020 •
edited
Loading

Codecov Report

Merging #27797 (b509d43) into master (4b1000f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #27797   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          390       390           
  Lines         7393      7395    +2     
  Branches      2093      2095    +2     
=========================================
+ Hits          7393      7395    +2
Impacted Files Coverage Δ
components/config-provider/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b1000f...272dc6b. Read the comment docs.

@afc163 afc163 merged commit f4c7058 into master Nov 16, 2020
@afc163 afc163 deleted the fix-modal-confirm-locale branch November 16, 2020 12:21
@afc163 afc163 mentioned this pull request Nov 16, 2020
Merged
@chenshuai2144 chenshuai2144 mentioned this pull request Nov 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@afc163 @ant-design-bot