feat: bump rc-collapse version
#27790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c61840b:
|
|
Size Change: -5.88 kB (0%) Total Size: 804 kB
|
kerm1it
force-pushed
the
new-collapse
branch
from
08c8214 to
2abc091
Compare
Codecov Report
@@ Coverage Diff @@
## feature #27790 +/- ##
===========================================
- Coverage 100.00% 99.90% -0.10%
===========================================
Files 393 392 -1
Lines 7371 7356 -15
Branches 2054 2104 +50
===========================================
- Hits 7371 7349 -22
- Misses 0 7 +7
Continue to review full report at Codecov.
|
zombieJ
commented
Nov 17, 2020
afc163
reviewed
Nov 17, 2020
|
看图片 diff 像是三角变宽了 |
kerm1it
force-pushed
the
new-collapse
branch
from
f714805 to
e59289b
Compare
kerm1it
reviewed
Nov 24, 2020
|
@zombieJ 没问题的话，这个可以合了 |
|
这个 PR 我发的，我不能 Approve 😂 |
|
changelog 补一下。 |
xrkffgg
approved these changes
Nov 27, 2020
afc163
reviewed
Nov 27, 2020
yoyo837
reviewed
Nov 27, 2020
yoyo837
reviewed
Nov 27, 2020
kerm1it
force-pushed
the
new-collapse
branch
from
6610a49 to
a188548
Compare
sammarks
added a commit
to sammarks/ant-design
that referenced
this pull request
Nov 30, 2020
It looks like this was broken in ant-design#27790. According to `rc-collapse`, the `collapsible` prop inside Collapse.Panel is optional, so it should be optional here as well if we're just forwarding props directly to the child component.
19 tasks
kerm1it
pushed a commit
that referenced
this pull request
Dec 1, 2020
It looks like this was broken in #27790. According to `rc-collapse`, the `collapsible` prop inside Collapse.Panel is optional, so it should be optional here as well if we're just forwarding props directly to the child component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
rc-animatewithrc-motionto implement animation; Deprecatedisabledof Panel; Addcollapsibleto support specify the trigger area of collapsible.rc-motion代替rc-animate实现动画；废弃 Panel 的disabled属性； 添加collapsible以支持指定可折叠触发区域。☑️ Self Check before Merge