refactor(checkbox): rewrite with hook #27739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0c7d3c9:
|
|
Size Change: -19.8 kB (2%) Total Size: 788 kB
|
Codecov Report
@@ Coverage Diff @@
## master #27739 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 389 389
Lines 7331 7323 -8
Branches 2034 2079 +45
=========================================
- Hits 7331 7323 -8
Continue to review full report at Codecov.
|
xrkffgg
reviewed
Nov 19, 2020
| @@ -1280,7 +1280,6 @@ exports[`Transfer should support render value and label in item 1`] = ` | |||
| > | |||
| <Checkbox | |||
| checked={false} | |||
| indeterminate={false} | |||
There was a problem hiding this comment.
我看 indeterminate 默认是 false，这个 snap 删除了是预期的吗？
|
/rebase |
github-actions
bot
force-pushed
the
r/c
branch
from
fc44e40 to
0c7d3c9
Compare
xrkffgg
approved these changes
Nov 19, 2020
|
记得更新一下 https://github.com/ant-design/ant-design/projects/6 ，方面跟踪进度。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self Check before Merge