Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: fix Avatar src Image style #27691

Merged
merged 4 commits into from
Nov 11, 2020
Merged

style: fix Avatar src Image style #27691

merged 4 commits into from
Nov 11, 2020

Conversation

hengkx
Copy link
Member

@hengkx hengkx commented Nov 11, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English fix Avatar src Image style.
🇨🇳 Chinese 修复 Avatar src 为 Image 时的样式。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Nov 11, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 11, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b0f9031:

Sandbox Source
antd reproduction template Configuration
Skeleton Issue #27690

@codecov
Copy link

codecov bot commented Nov 11, 2020

Codecov Report

Merging #27691 (b0f9031) into master (6a1e9b0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #27691   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          390       390           
  Lines         7395      7395           
  Branches      2041      2041           
=========================================
  Hits          7395      7395           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a1e9b0...b0f9031. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2020

Size Change: +29 B (0%)

Total Size: 790 kB

Filename Size Change
./dist/antd.compact.min.css 66.4 kB +9 B (0%)
./dist/antd.dark.min.css 67.7 kB +10 B (0%)
./dist/antd.min.css 66.4 kB +10 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd-with-locales.min.js 313 kB 0 B
./dist/antd.min.js 277 kB 0 B

compressed-size-action

@afc163
Copy link
Member

afc163 commented Nov 11, 2020

https://ant.design/components/avatar-cn/#components-avatar-demo-type

这个例子看着是好的,是哪里出了问题?

@hengkx
Copy link
Member Author

hengkx commented Nov 11, 2020

这个例子 没有设置 size number吧

@afc163
Copy link
Member

afc163 commented Nov 11, 2020

有的
image

@afc163
Copy link
Member

afc163 commented Nov 11, 2020

另外右边的头像有点偏下,顺手一起修一下吧。

image

@hengkx
Copy link
Member Author

hengkx commented Nov 11, 2020

image
这个里面 不是图片

@afc163
Copy link
Member

afc163 commented Nov 11, 2020

图片的也没问题,你可以试试。

@hengkx
Copy link
Member Author

hengkx commented Nov 11, 2020

@hengkx
Copy link
Member Author

hengkx commented Nov 11, 2020

他没 加样式。。。。。。。。。。。。。

@afc163
Copy link
Member

afc163 commented Nov 11, 2020

那就修一下 #27691 (comment) 吧。。

@hengkx hengkx changed the title style: fix Avatar size number style style: fix Avatar src Image style Nov 11, 2020
@hengkx hengkx requested a review from afc163 November 11, 2020 07:06
@afc163
Copy link
Member

afc163 commented Nov 11, 2020

PR 内容改改

@hengkx
Copy link
Member Author

hengkx commented Nov 11, 2020

PR 内容改改

改过了🤣

@afc163
Copy link
Member

afc163 commented Nov 11, 2020

#27690 没关系了。

@afc163
Copy link
Member

afc163 commented Nov 11, 2020

#27690 去回复一下直接关掉吧。

@hengkx
Copy link
Member Author

hengkx commented Nov 11, 2020

done

@afc163 afc163 merged commit b3e75d5 into master Nov 11, 2020
@afc163 afc163 deleted the fix-27690 branch November 11, 2020 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants