Allow overlayInnerStyle to pass through in Tooltip component #27682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the innerStyle is only passed if a color is provided which does not match the preset colors. This fix allows `overlayInnerStyle` to pass through regardless of the value of `color`.
jasepellerin
force-pushed
the
overlayInnerStyle
branch
from
be883a8 to
5197871
Compare
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5197871:
|
Codecov Report
@@ Coverage Diff @@
## master #27682 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 390 390
Lines 7404 7405 +1
Branches 2083 2042 -41
=========================================
+ Hits 7404 7405 +1
Continue to review full report at Codecov.
|
jasepellerin
changed the title
Merged
This was referenced Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the innerStyle is only passed if a color is provided which does not match the preset colors. This fix allows
overlayInnerStyleto pass through regardless of the value ofcolor.[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
It is useful to pass styles through to the inner container, but this wasn't possible without also passing a non-preset color. This changes simply allows the
overlayInnerStyleprop to pass through to the child in all cases.📝 Changelog
overlayInnerStylebut not seeing styles passed through will see a change.☑️ Self Check before Merge