Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: UPDATE menu version #27663

Merged
merged 13 commits into from
Nov 11, 2020
Merged

chore: UPDATE menu version #27663

merged 13 commits into from
Nov 11, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Nov 9, 2020 •
edited by kerm1it
Loading

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #26979

fix #26905

fix #26970

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Menu dropdown animation start twice when appear.
🇨🇳 Chinese 修复 Menu 下拉框显示时动画会播放两次的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@zombieJ zombieJ changed the title chore: UPDATE menu version [WIP] chore: UPDATE menu version Nov 9, 2020
@pr-triage pr-triage bot removed the PR: unreviewed label Nov 9, 2020
@zombieJ zombieJ requested review from afc163 and kerm1it November 9, 2020 14:11
@zombieJ
Copy link
Member Author

zombieJ commented Nov 9, 2020

测一波~~

@kerm1it
Copy link
Member

kerm1it commented Nov 9, 2020

这里有一个呢 #27431

@kerm1it
Copy link
Member

kerm1it commented Nov 9, 2020

那我把那个关了，用这个测

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Nov 9, 2020 •
edited
Loading

@zombieJ
Copy link
Member Author

zombieJ commented Nov 9, 2020

疏忽，疏忽……都是 master 的直接测 8.10.0 好了。

@kerm1it kerm1it mentioned this pull request Nov 9, 2020
Closed
19 tasks
@kerm1it
Copy link
Member

kerm1it commented Nov 9, 2020

测试挂了

@zombieJ
Copy link
Member Author

zombieJ commented Nov 9, 2020

嗯，先测测表现。我另一个 PR 弄好回头修这个 test

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2020 •
edited
Loading

Size Change: +10.8 kB (1%)

Total Size: 801 kB

Filename Size Change
./dist/antd-with-locales.min.js 319 kB +5.38 kB (1%)
./dist/antd.compact.min.css 66.4 kB +51 B (0%)
./dist/antd.dark.min.css 67.7 kB +53 B (0%)
./dist/antd.min.css 66.4 kB +55 B (0%)
./dist/antd.min.js 282 kB +5.28 kB (1%)

compressed-size-action

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 9, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 11ec232:

Sandbox Source
antd reproduction template Configuration
antd-submenu-bug Issue #26905
popover-menu 组合问题重现 Issue #26970

@kerm1it
Copy link
Member

kerm1it commented Nov 9, 2020

Nov-09-2020 22-33-09
这个切换动画是不是不太正常？

@kerm1it
Copy link
Member

kerm1it commented Nov 9, 2020

@zombieJ 看看这个，切换后消失不了

https://codesandbox.io/s/popover-menu-zuhewentichongxian-forked-01zmz

@zombieJ
Copy link
Member Author

zombieJ commented Nov 9, 2020

看了一下 timeline 是对的，不正常指的是？

截屏2020-11-09 下午10 38 45

@zombieJ
Copy link
Member Author

zombieJ commented Nov 9, 2020

看起来是 codesandbox 缓存了 rc-trigger。这个 bug 已经修过了。

@kerm1it
Copy link
Member

kerm1it commented Nov 9, 2020 •
edited
Loading

看起来是 codesandbox 缓存了 rc-trigger。这个 bug 已经修过了。

本地复现了，你本地试试

image

这个例子

按 合并按钮然后切换一下菜单

@zombieJ
Copy link
Member Author

zombieJ commented Nov 9, 2020

指的是什么？框不消失还是什么？

@codecov
Copy link

codecov bot commented Nov 10, 2020 •
edited
Loading

Codecov Report

Merging #27663 (de25989) into master (9881be9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #27663   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          390       390           
  Lines         7404      7404           
  Branches      2083      2093   +10     
=========================================
  Hits          7404      7404

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9881be9...592feba. Read the comment docs.

@afc163

This comment has been minimized.

Sign in to view
@afc163
Copy link
Member

afc163 commented Nov 10, 2020

vertical menu 的弹出动画变成 zoom 了，应该是从展开位置弹出。

@zombieJ
Copy link
Member Author

zombieJ commented Nov 10, 2020

先测测缩放闪动，placement 我继续看看

@zombieJ
Copy link
Member Author

zombieJ commented Nov 10, 2020

再看看，好了我准备 rc-menu 发个 minor 了~

@kerm1it
Copy link
Member

kerm1it commented Nov 10, 2020

我这试了试，没什么问题了。

@kerm1it
Copy link
Member

kerm1it commented Nov 10, 2020

@afc163 你再点点看看，确认一下

@afc163
Copy link
Member

afc163 commented Nov 10, 2020

bundle size 超了好多。

@afc163
Copy link
Member

afc163 commented Nov 10, 2020

argos 怎么这么多 diff。

@zombieJ
Copy link
Member Author

zombieJ commented Nov 10, 2020

因为 rc-menu 现在两个版本，发 minor 就好了

@zombieJ
Copy link
Member Author

zombieJ commented Nov 10, 2020

pagination 的，我合个 master 就好了

@kerm1it
Copy link
Member

kerm1it commented Nov 10, 2020

我看package.json里面还是4.8.0

@zombieJ
Copy link
Member Author

zombieJ commented Nov 10, 2020 •
edited
Loading

8.9.x 我看是没有特别的 feature，合 master 是 ok 的。你可以确认一下~

@kerm1it
Copy link
Member

kerm1it commented Nov 10, 2020

可以，8.9.x 没有新功能。

@afc163
Copy link
Member

afc163 commented Nov 11, 2020 •
edited
Loading

RTL 样式有点问题

image

其他没问题了，修了可发。

@zombieJ
Copy link
Member Author

zombieJ commented Nov 11, 2020 •
edited
Loading

fixed. CI 过了我发版本去

@zombieJ zombieJ merged commit a987f7f into master Nov 11, 2020
@zombieJ zombieJ deleted the dark-menu branch November 11, 2020 11:05
@afc163
Copy link
Member

afc163 commented Nov 12, 2020

体积多了 5kb，要去重一下。

@afc163 afc163 mentioned this pull request Nov 13, 2020
Merged
19 tasks
@chenshuai2144 chenshuai2144 mentioned this pull request Nov 14, 2020
Merged
@xrkffgg xrkffgg mentioned this pull request Jan 6, 2021
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kerm1it kerm1it kerm1it approved these changes

@afc163 afc163 Awaiting requested review from afc163

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@zombieJ @kerm1it @ant-design-bot @afc163