Prevent Input.Search component to throw passing null as enterButton prop value #27591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 19d6a22:
|
Codecov Report
@@ Coverage Diff @@
## master #27591 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 390 390
Lines 7415 7415
Branches 2083 2084 +1
=========================================
Hits 7415 7415
Continue to review full report at Codecov.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
No open issue
💡 Background and solution
The type of
enterButtonproperty is ReactNode, which accept thenullvalue. In the code, it is performed aenterButton.typeoperation, resulting in a js error. With the default value, false, it is not an error becausefalse.type === undefined.📝 Changelog
It is possible to pass
nullasenterButtonvalue without throw.☑️ Self Check before Merge