Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Avatar group size #27531

Merged
merged 2 commits into from
Nov 5, 2020
Merged

fix: Avatar group size #27531

merged 2 commits into from
Nov 5, 2020

Conversation

hengkx
Copy link
Member

@hengkx hengkx commented Nov 4, 2020 •
edited
Loading

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #27530

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English fix Avatar.Group size invalid.
🇨🇳 Chinese 修复 Avatar.Group 的 size 不生效问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Nov 4, 2020 •
edited
Loading

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 4, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit feb29c4:

Sandbox Source
antd reproduction template Configuration

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2020 •
edited
Loading

Size Change: +80 B (0%)

Total Size: 790 kB

Filename Size Change
./dist/antd-with-locales.min.js 313 kB +35 B (0%)
./dist/antd.min.js 277 kB +45 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd.compact.min.css 66.4 kB 0 B
./dist/antd.dark.min.css 67.7 kB 0 B
./dist/antd.min.css 66.4 kB 0 B

compressed-size-action

@codecov
Copy link

codecov bot commented Nov 4, 2020 •
edited
Loading

Codecov Report

Merging #27531 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #27531   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          389       390    +1     
  Lines         7408      7414    +6     
  Branches      2088      2042   -46     
=========================================
+ Hits          7408      7414    +6
Impacted Files Coverage Δ
components/avatar/group.tsx 100.00% <ø> (ø)
components/avatar/SizeContext.tsx 100.00% <100.00%> (ø)
components/avatar/avatar.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cba9634...feb29c4. Read the comment docs.

@hengkx
Copy link
Member Author

hengkx commented Nov 4, 2020

/rebase

@hengkx hengkx requested a review from xrkffgg November 5, 2020 05:30
@xrkffgg
Copy link
Member

xrkffgg commented Nov 5, 2020

我看还是小的？我拉到本地看看

@xrkffgg
Copy link
Member

xrkffgg commented Nov 5, 2020

用法变了？

@hengkx
Copy link
Member Author

hengkx commented Nov 5, 2020

没变吧

@xrkffgg
Copy link
Member

xrkffgg commented Nov 5, 2020

你那看着 size 生效了吗？

@hengkx
Copy link
Member Author

hengkx commented Nov 5, 2020

我脑残了

xrkffgg
xrkffgg approved these changes Nov 5, 2020
View reviewed changes
components/avatar/SizeContext.tsx Show resolved Hide resolved
@hengkx hengkx merged commit 9772a63 into master Nov 5, 2020
@hengkx hengkx deleted the fix-27530 branch November 5, 2020 08:22
@afc163 afc163 mentioned this pull request Nov 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrkffgg xrkffgg xrkffgg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avatar group size
3 participants
@hengkx @ant-design-bot @xrkffgg