Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Row support wrap #27469

Merged
merged 7 commits into from
Oct 30, 2020
Merged

feat: Row support wrap #27469

merged 7 commits into from
Oct 30, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Oct 30, 2020 •
edited by markdownify bot
Loading

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

resolve #27463

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Row support noWrap to make Col in line.
🇨🇳 Chinese Row 支持 noWrap 属性以使 Col 不错行。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/grid/demo/flex-stretch.md

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Oct 30, 2020 •
edited
Loading

@lgtm-com
Copy link

lgtm-com bot commented Oct 30, 2020

This pull request introduces 1 alert when merging 384090e into 4ec9e23 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@zombieJ zombieJ changed the title feat: Row support noWrap [WIP] feat: Row support noWrap Oct 30, 2020
@zombieJ zombieJ changed the title [WIP] feat: Row support noWrap feat: Row support noWrap Oct 30, 2020
@zombieJ zombieJ changed the title feat: Row support noWrap feat: Row support wrap Oct 30, 2020
@github-actions
Copy link
Contributor

Size Change: +165 B (0%)

Total Size: 792 kB

Filename Size Change
./dist/antd-with-locales.min.js 314 kB +66 B (0%)
./dist/antd.compact.min.css 66.5 kB +9 B (0%)
./dist/antd.dark.min.css 67.8 kB +11 B (0%)
./dist/antd.min.css 66.5 kB +9 B (0%)
./dist/antd.min.js 277 kB +70 B (0%)

compressed-size-action

kerm1it
kerm1it reviewed Oct 30, 2020
View reviewed changes
components/grid/row.tsx
@@ -18,6 +18,7 @@ export interface RowProps extends React.HTMLAttributes<HTMLDivElement> {
align?: typeof RowAligns[number];
justify?: typeof RowJustify[number];
prefixCls?: string;
wrap?: boolean;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是不是加个默认值为 true， 用 undefined 表示 true 总感觉有点绕。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一般不复杂的地方我习惯不加，uglify 能省点

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ef890a1:

Sandbox Source
antd reproduction template Configuration
antdFlexTable Issue #27463

@codecov
Copy link

codecov bot commented Oct 30, 2020 •
edited
Loading

Codecov Report

Merging #27469 into feature will increase coverage by 1.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           feature    #27469      +/-   ##
============================================
+ Coverage    98.81%   100.00%   +1.18%     
============================================
  Files          363       389      +26     
  Lines         7280      7397     +117     
  Branches      1967      2075     +108     
============================================
+ Hits          7194      7397     +203     
+ Misses          86         0      -86
Impacted Files Coverage Δ
components/_util/easings.ts 100.00% <ø> (ø)
components/_util/hooks/usePatchElement.tsx 100.00% <ø> (ø)
components/_util/scrollTo.ts 100.00% <ø> (ø)
components/_util/type.ts 100.00% <ø> (ø)
components/affix/index.tsx 100.00% <ø> (+0.86%) ⬆️
components/button/LoadingIcon.tsx 100.00% <ø> (ø)
components/collapse/Collapse.tsx 100.00% <ø> (ø)
components/collapse/CollapsePanel.tsx 100.00% <ø> (ø)
components/collapse/openAnimation.tsx 100.00% <ø> (ø)
components/_util/hooks/useCombinedRefs.tsx 100.00% <100.00%> (ø)
... and 199 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6f3166...ef890a1. Read the comment docs.

@zombieJ zombieJ merged commit d052543 into feature Oct 30, 2020
@zombieJ zombieJ deleted the noWrap branch October 30, 2020 14:13
@xrkffgg xrkffgg mentioned this pull request Nov 2, 2020
Merged
@jddxf jddxf mentioned this pull request Jul 30, 2021
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afc163 afc163 afc163 left review comments

@kerm1it kerm1it kerm1it approved these changes

@hengkx hengkx hengkx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zombieJ @ant-design-bot @afc163 @hengkx @kerm1it