Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Desc label with flex node #27375

Merged
merged 5 commits into from
Oct 26, 2020
Merged

fix: Desc label with flex node #27375

merged 5 commits into from
Oct 26, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Oct 26, 2020 •
edited by markdownify bot
Loading

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#25903 (comment)

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Description style when label use block element.
🇨🇳 Chinese 修复 Description 在 label 自定义为块状元素时的样式问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/descriptions/demo/text.md

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Oct 26, 2020 •
edited
Loading

@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2020 •
edited
Loading

Size Change: +10 B (0%)

Total Size: 792 kB

Filename Size Change
./dist/antd.compact.min.css 66.5 kB +4 B (0%)
./dist/antd.dark.min.css 67.8 kB +4 B (0%)
./dist/antd.min.css 66.5 kB +2 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd-with-locales.min.js 314 kB 0 B
./dist/antd.min.js 277 kB 0 B

compressed-size-action

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 26, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 298144e:

Sandbox Source
antd reproduction template Configuration

@paranoidjk
Copy link
Contributor

https://github.com/ant-design/ant-design/blob/master/components/descriptions/style/index.less#L97
这个老样式不用删除吗？

@zombieJ
Copy link
Member Author

zombieJ commented Oct 26, 2020

嗯，没用了。删

@codecov
Copy link

codecov bot commented Oct 26, 2020 •
edited
Loading

Codecov Report

Merging #27375 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #27375   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          389       389           
  Lines         7383      7383           
  Branches      2026      2078   +52     
=========================================
  Hits          7383      7383

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c84cd88...298144e. Read the comment docs.

@zombieJ zombieJ merged commit 59a1332 into master Oct 26, 2020
@zombieJ zombieJ deleted the fix-desc branch October 26, 2020 10:40
@xrkffgg xrkffgg mentioned this pull request Nov 2, 2020
Merged
07akioni pushed a commit that referenced this pull request Nov 7, 2020
@zombieJ @07akioni
fix: Desc label with flex node (#27375)
93456fc 
* fix: Desc label with flex node

* test: Update snapshot

* rm useless css

* more style

* rm useless code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoyo837 yoyo837 yoyo837 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zombieJ @ant-design-bot @paranoidjk @yoyo837