Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Table summary support align #27365

Merged
merged 1 commit into from
Oct 26, 2020
Merged

feat: Table summary support align #27365

merged 1 commit into from
Oct 26, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Oct 26, 2020 •
edited
Loading

[中文版模板 / Chinese template]

close #26866

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

resolve #26866

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Table.Summary.Cell support align prop.
🇨🇳 Chinese Table.Summary.Cell 支持 align 配置。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@afc163
Copy link
Member

afc163 commented Oct 26, 2020

最好把 react-component/table#503 一起搞了，这个更实用。

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Oct 26, 2020 •
edited
Loading

@zombieJ
Copy link
Member Author

zombieJ commented Oct 26, 2020

最好把 react-component/table#503 一起搞了，这个更实用。

rc-table 发过版了，这个先合了。那个我瞅瞅再发个版本。

@hengkx
Copy link
Member

hengkx commented Oct 26, 2020

close #26866

@github-actions
Copy link
Contributor

Size Change: +10 B (0%)

Total Size: 792 kB

Filename Size Change
./dist/antd-with-locales.min.js 314 kB +5 B (0%)
./dist/antd.min.js 277 kB +5 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd.compact.min.css 66.5 kB 0 B
./dist/antd.dark.min.css 67.8 kB 0 B
./dist/antd.min.css 66.5 kB 0 B

compressed-size-action

@zombieJ zombieJ merged commit 23f8cce into feature Oct 26, 2020
@zombieJ zombieJ deleted the bump-table branch October 26, 2020 03:32
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d91514f:

Sandbox Source
antd reproduction template Configuration

@dongxiaoyong009
Copy link

顶一个，今天刚遇到这个 Summary 不能设置 align 的问题， 最好可以默认继承 table的 columns里的 align 配置。 因为单独在配置一遍有些繁琐

@xrkffgg xrkffgg mentioned this pull request Nov 2, 2020
Merged
07akioni pushed a commit that referenced this pull request Nov 7, 2020
@zombieJ @07akioni
feat: Table summary support align (#27365)
7c1d1f6
@ps2qwert
Copy link

ps2qwert commented Apr 1, 2021

最好把 react-component/table#503 一起搞了，这个更实用。

rc-table 发过版了，这个先合了。那个我瞅瞅再发个版本。

问下这个合了嘛，Summary定位不起作用啊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrkffgg xrkffgg xrkffgg approved these changes

@hengkx hengkx hengkx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@zombieJ @afc163 @ant-design-bot @hengkx @dongxiaoyong009 @ps2qwert @xrkffgg