Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ConfigProvider add form requiredMark #27322

Merged
merged 2 commits into from
Oct 24, 2020
Merged

feat: ConfigProvider add form requiredMark #27322

merged 2 commits into from
Oct 24, 2020

Conversation

hengkx
Copy link
Member

@hengkx hengkx commented Oct 23, 2020 •
edited by markdownify bot
Loading

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #27317

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English ConfigProvider add form requiredMark.
🇨🇳 Chinese ConfigProvider 增加 form requiredMark 配置。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/config-provider/index.en-US.md
View rendered components/config-provider/index.zh-CN.md

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Oct 23, 2020 •
edited
Loading

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Oct 23, 2020 •
edited
Loading

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 23, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 62dad24:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Oct 23, 2020 •
edited
Loading

Codecov Report

Merging #27322 into feature will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           feature    #27322   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          389       389           
  Lines         7393      7397    +4     
  Branches      2027      2071   +44     
=========================================
+ Hits          7393      7397    +4
Impacted Files Coverage Δ
components/config-provider/context.tsx 100.00% <ø> (ø)
components/config-provider/index.tsx 100.00% <100.00%> (ø)
components/form/Form.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4c6740...62dad24. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2020 •
edited
Loading

Size Change: +46 B (0%)

Total Size: 792 kB

Filename Size Change
./dist/antd-with-locales.min.js 314 kB +22 B (0%)
./dist/antd.min.js 278 kB +24 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd.compact.min.css 66.4 kB 0 B
./dist/antd.dark.min.css 67.7 kB 0 B
./dist/antd.min.css 66.4 kB 0 B

compressed-size-action

@hengkx hengkx requested review from xrkffgg and zombieJ October 23, 2020 09:20
@zombieJ zombieJ merged commit 7e782da into feature Oct 24, 2020
@zombieJ zombieJ deleted the config branch October 24, 2020 06:27
@xrkffgg xrkffgg mentioned this pull request Nov 2, 2020
Merged
07akioni pushed a commit that referenced this pull request Nov 7, 2020
@hengkx @07akioni
feat: ConfigProvider add form requiredMark (#27322)
53daf58 
* feat: ConfigProvider add form requiredMark

* Update Form.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zombieJ zombieJ zombieJ approved these changes

@xrkffgg xrkffgg Awaiting requested review from xrkffgg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hengkx @ant-design-bot @zombieJ @xrkffgg