Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🐛 Tabs animated={true} should works #27145

Merged
merged 1 commit into from
Oct 14, 2020
Merged

fix: 🐛 Tabs animated={true} should works #27145

merged 1 commit into from
Oct 14, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Oct 14, 2020 •
edited
Loading

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #27135

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Tabs animated={true} not working for panels.
🇨🇳 Chinese 修复 Tabs animated 属性为 true 时未开启内容切换动画的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/tabs/index.en-US.md
View rendered components/tabs/index.zh-CN.md

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Oct 14, 2020 •
edited
Loading

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Oct 14, 2020 •
edited
Loading

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 14, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bae457b:

Sandbox Source
antd reproduction template Configuration

@afc163
Copy link
Member Author

afc163 commented Oct 14, 2020

/rebase

@github-actions
Copy link
Contributor

Size Change: +36 B (0%)

Total Size: 791 kB

Filename Size Change
./dist/antd-with-locales.min.js 313 kB +16 B (0%)
./dist/antd.min.js 277 kB +20 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd.compact.min.css 66.2 kB 0 B
./dist/antd.dark.min.css 67.5 kB 0 B
./dist/antd.min.css 66.2 kB 0 B

compressed-size-action

@codecov
Copy link

codecov bot commented Oct 14, 2020 •
edited
Loading

Codecov Report

Merging #27145 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #27145   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          388       388           
  Lines         7392      7392           
  Branches      2021      2063   +42     
=========================================
  Hits          7392      7392

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bdd7c1...bae457b. Read the comment docs.

@afc163 afc163 merged commit 50d8c38 into master Oct 14, 2020
@afc163 afc163 deleted the fix-tabs-animated branch October 14, 2020 08:34
@chenshuai2144 chenshuai2144 mentioned this pull request Oct 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afc163 @ant-design-bot