Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: InputNumber support onStep #27075

Merged
merged 3 commits into from
Oct 10, 2020
Merged

feat: InputNumber support onStep #27075

merged 3 commits into from
Oct 10, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Oct 10, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

react-component/input-number#269

close #17139

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English InputNumber will trigger onStep when click up/down buttons
🇨🇳 Chinese InputNumber 点击上下按钮时将触发 onStep

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

Prepare preview

@ant-design-bot
Copy link
Contributor

UI Testing

@afc163 afc163 merged commit 94cab40 into master Oct 10, 2020
@afc163 afc163 deleted the input-number-on-step branch October 10, 2020 09:49
@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2020

Size Change: -589 B (0%)

Total Size: 792 kB

Filename Size Change
./dist/antd-with-locales.min.js 313 kB -283 B (0%)
./dist/antd.min.js 277 kB -306 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd.compact.min.css 66.5 kB 0 B
./dist/antd.dark.min.css 67.8 kB 0 B
./dist/antd.min.css 66.5 kB 0 B

compressed-size-action

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5a8edae:

Sandbox Source
antd reproduction template Configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

如何区分InputNumber的输入和右侧的上下点击触发的onChange
2 participants