Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sliderProps typeScript define #27033

Merged
merged 4 commits into from
Oct 9, 2020
Merged

fix: sliderProps typeScript define #27033

merged 4 commits into from
Oct 9, 2020

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Oct 8, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

react-component/slider#689

📝 Changelog

Language Changelog
🇺🇸 English Fix sliderProps typeScript define.
🇨🇳 Chinese 修复 sliderProps typeScript 定义。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Oct 8, 2020 •
edited
Loading

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Oct 8, 2020 •
edited
Loading

@xrkffgg xrkffgg requested review from afc163 and yoyo837 October 8, 2020 09:21
@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 8, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9fc6739:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Oct 8, 2020 •
edited
Loading

Codecov Report

Merging #27033 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #27033   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          384       384           
  Lines         7369      7369           
  Branches      2009      2061   +52     
=========================================
  Hits          7369      7369
Impacted Files Coverage Δ
components/slider/index.tsx 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df8c53d...9fc6739. Read the comment docs.

@hengkx
Copy link
Member

hengkx commented Oct 9, 2020

Conflicting files. 这个是不是能解决 我那边的 ci failed.

@yoyo837 yoyo837 mentioned this pull request Oct 9, 2020
Merged
19 tasks
@hengkx hengkx merged commit b173b5b into master Oct 9, 2020
@hengkx hengkx deleted the ts-slider branch October 9, 2020 01:37
@xrkffgg xrkffgg mentioned this pull request Oct 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afc163 afc163 Awaiting requested review from afc163

@yoyo837 yoyo837 Awaiting requested review from yoyo837

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xrkffgg @ant-design-bot @hengkx