style: fix Radio.Button validation error highlight #26849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ece68ae:
|
Codecov Report
@@ Coverage Diff @@
## master #26849 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 384 384
Lines 7365 7365
Branches 2056 2007 -49
=========================================
Hits 7365 7365 Continue to review full report at Codecov.
|
dhorelik
force-pushed
the
radio-button-validation-error
branch
from
26f917a to
ece68ae
Compare
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
This partially covers #24590
💡 Background and solution
Form.Item validateStatus has no effect on the contained Radio.Button styling. Error color should be used for borders to match other form controls (input, select, etc).
📝 Changelog
☑️ Self Check before Merge
View rendered components/form/demo/validate-other.md