Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: fix description item long text #26820

Merged
merged 2 commits into from
Sep 19, 2020
Merged

style: fix description item long text #26820

merged 2 commits into from
Sep 19, 2020

Conversation

hengkx
Copy link
Member

@hengkx hengkx commented Sep 18, 2020 •
edited
Loading

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English fix Descriptions item long text style.
🇨🇳 Chinese 修复 Descriptions 长文本移除样式的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@afc163
Copy link
Member

afc163 commented Sep 18, 2020

image

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Sep 18, 2020 •
edited
Loading

UI Testing

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Sep 18, 2020 •
edited
Loading

@github-actions
Copy link
Contributor

github-actions bot commented Sep 18, 2020 •
edited
Loading

Size Change: -4 B (0%)

Total Size: 796 kB

Filename Size Change
./dist/antd.dark.min.css 67.6 kB -2 B (0%)
./dist/antd.min.css 66.4 kB -2 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd-with-locales.min.js 315 kB 0 B
./dist/antd.compact.min.css 66.4 kB 0 B
./dist/antd.min.js 281 kB 0 B

compressed-size-action

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 18, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 411c31c:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Sep 18, 2020 •
edited
Loading

Codecov Report

Merging #26820 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #26820   +/-   ##
=======================================
  Coverage   99.91%   99.91%           
=======================================
  Files         384      384           
  Lines        7368     7368           
  Branches     2057     2050    -7     
=======================================
  Hits         7362     7362           
  Misses          6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea3629d...411c31c. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Sep 18, 2020

fix description item long text style
修复description长文本样式

  1. 补上标点。
  2. 中英文之间加空格。
  3. 使用正确的组件名 Descriptions。
  4. 适当补充细节，使其表述明确：修复 ... 长文本溢出的样式问题。。

@hengkx hengkx requested a review from afc163 September 18, 2020 12:33
@hengkx
Copy link
Member Author

hengkx commented Sep 18, 2020

image
这是什么问题？

@zombieJ zombieJ merged commit 3ab7122 into master Sep 19, 2020
@zombieJ zombieJ deleted the style-description branch September 19, 2020 15:17
@zombieJ zombieJ mentioned this pull request Sep 20, 2020
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afc163 afc163 Awaiting requested review from afc163

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hengkx @afc163 @ant-design-bot @zombieJ