Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add loading prop for Statistic #26811

Merged
merged 9 commits into from
Oct 23, 2020

Conversation

appleshell
Copy link
Contributor

@appleshell appleshell commented Sep 18, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #26248

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English add loading prop for Statistic
🇨🇳 Chinese Statistic组件增加loading属性

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/statistic/demo/basic.md
View rendered components/statistic/index.zh-CN.md

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Sep 18, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Sep 18, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 18, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 813d59d:

Sandbox Source
antd reproduction template Configuration

@appleshell appleshell changed the title Feature statistic loading feat: add loading prop for Statistic Sep 18, 2020
@codecov
Copy link

codecov bot commented Sep 18, 2020

Codecov Report

Merging #26811 into feature will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           feature    #26811   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          389       389           
  Lines         7393      7393           
  Branches      2027      2069   +42     
=========================================
  Hits          7393      7393           
Impacted Files Coverage Δ
components/statistic/Statistic.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcc05fc...813d59d. Read the comment docs.

@zombieJ
Copy link
Member

zombieJ commented Sep 24, 2020

Seems mixed with other commit?

@appleshell appleshell force-pushed the feature-statistic-loading branch from 1b9ace0 to e350962 Compare September 24, 2020 04:35
@appleshell
Copy link
Contributor Author

done.

@zombieJ
Copy link
Member

zombieJ commented Sep 24, 2020

Wait for #26883

@appleshell appleshell force-pushed the feature-statistic-loading branch from e350962 to 590ab4d Compare October 20, 2020 12:08
@hengkx
Copy link
Member

hengkx commented Oct 22, 2020

conflict

@appleshell appleshell force-pushed the feature-statistic-loading branch from 590ab4d to 813d59d Compare October 22, 2020 02:41
@zombieJ zombieJ merged commit b4c6740 into ant-design:feature Oct 23, 2020
@appleshell appleshell deleted the feature-statistic-loading branch November 3, 2020 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants