Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: FormItem support generate for renderProps #26791

Merged
merged 1 commit into from
Sep 17, 2020
Merged

feat: FormItem support generate for renderProps #26791

merged 1 commit into from
Sep 17, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Sep 17, 2020 •
edited
Loading

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

resolve #26775

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Update Form ts definition to support getFieldsValue return generic type without namePath argument.
🇨🇳 Chinese 调整 Form ts 定义，现在当 getFieldsValue 不配置 namePath 时返回类型为 FormValue 的泛型定义。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Sep 17, 2020 •
edited
Loading

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Sep 17, 2020 •
edited
Loading

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2c3db97:

Sandbox Source
antd reproduction template Configuration

@github-actions
Copy link
Contributor

Size Change: 0 B

Total Size: 881 kB

ℹ️ View Unchanged
Filename Size Change
./dist/antd-with-locales.min.js 357 kB 0 B
./dist/antd.compact.min.css 66.4 kB 0 B
./dist/antd.dark.min.css 67.6 kB 0 B
./dist/antd.min.css 66.4 kB 0 B
./dist/antd.min.js 323 kB 0 B

compressed-size-action

@codecov
Copy link

codecov bot commented Sep 17, 2020 •
edited
Loading

Codecov Report

Merging #26791 into feature will increase coverage by 1.01%.
The diff coverage is 99.49%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #26791      +/-   ##
===========================================
+ Coverage    98.81%   99.83%   +1.01%     
===========================================
  Files          363      385      +22     
  Lines         7280     7394     +114     
  Branches      1967     2067     +100     
===========================================
+ Hits          7194     7382     +188     
+ Misses          86       12      -74
Impacted Files Coverage Δ
components/_util/easings.ts 100.00% <ø> (ø)
components/_util/hooks/usePatchElement.tsx 100.00% <ø> (ø)
components/_util/scrollTo.ts 100.00% <ø> (ø)
components/_util/type.ts 100.00% <ø> (ø)
components/affix/index.tsx 100.00% <ø> (+0.86%) ⬆️
components/button/LoadingIcon.tsx 100.00% <ø> (ø)
components/config-provider/context.tsx 100.00% <ø> (ø)
components/config-provider/index.tsx 100.00% <ø> (ø)
components/_util/motion.tsx 83.33% <83.33%> (-16.67%) ⬇️
components/alert/index.tsx 97.50% <96.15%> (-2.50%) ⬇️
... and 182 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a86b75...2c3db97. Read the comment docs.

@zombieJ zombieJ merged commit 1da6016 into feature Sep 17, 2020
@zombieJ zombieJ deleted the item-ts branch September 17, 2020 08:51
@afc163 afc163 mentioned this pull request Oct 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@07akioni 07akioni 07akioni approved these changes

@afc163 afc163 afc163 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zombieJ @ant-design-bot @afc163 @07akioni