Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Form.Item support tooltip #26780

Merged
merged 7 commits into from
Sep 17, 2020
Merged

feat: Form.Item support tooltip #26780

merged 7 commits into from
Sep 17, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Sep 16, 2020 •
edited by markdownify bot
Loading

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Form.Item support tooltip to customize tooltip.
🇨🇳 Chinese Form.Item 支持 tooltip 属性自定义提示信息。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/form/demo/required-mark.md
View rendered components/form/index.en-US.md
View rendered components/form/index.zh-CN.md

@zombieJ zombieJ requested a review from afc163 September 16, 2020 15:25
@ant-design-bot
Copy link
Contributor

ant-design-bot commented Sep 16, 2020 •
edited
Loading

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Sep 16, 2020 •
edited
Loading

@lgtm-com
Copy link

lgtm-com bot commented Sep 16, 2020

This pull request introduces 1 alert when merging 64643fe into 4a86b75 - view on LGTM.com

new alerts:

  • 1 for Useless conditional

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 16, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 25cab2b:

Sandbox Source
antd reproduction template Configuration

@github-actions
Copy link
Contributor

github-actions bot commented Sep 16, 2020 •
edited
Loading

Size Change: +1.12 kB (0%)

Total Size: 882 kB

Filename Size Change
./dist/antd-with-locales.min.js 358 kB +546 B (0%)
./dist/antd.compact.min.css 66.4 kB +51 B (0%)
./dist/antd.dark.min.css 67.7 kB +52 B (0%)
./dist/antd.min.css 66.4 kB +47 B (0%)
./dist/antd.min.js 324 kB +428 B (0%)

compressed-size-action

@lgtm-com
Copy link

lgtm-com bot commented Sep 16, 2020

This pull request introduces 1 alert when merging 0c01dba into 4a86b75 - view on LGTM.com

new alerts:

  • 1 for Useless conditional

@codecov
Copy link

codecov bot commented Sep 16, 2020 •
edited
Loading

Codecov Report

Merging #26780 into feature will increase coverage by 1.01%.
The diff coverage is 99.49%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #26780      +/-   ##
===========================================
+ Coverage    98.81%   99.83%   +1.01%     
===========================================
  Files          363      385      +22     
  Lines         7280     7405     +125     
  Branches      1967     2068     +101     
===========================================
+ Hits          7194     7393     +199     
+ Misses          86       12      -74
Impacted Files Coverage Δ
components/_util/easings.ts 100.00% <ø> (ø)
components/_util/hooks/usePatchElement.tsx 100.00% <ø> (ø)
components/_util/scrollTo.ts 100.00% <ø> (ø)
components/_util/type.ts 100.00% <ø> (ø)
components/affix/index.tsx 100.00% <ø> (+0.86%) ⬆️
components/button/LoadingIcon.tsx 100.00% <ø> (ø)
components/config-provider/context.tsx 100.00% <ø> (ø)
components/config-provider/index.tsx 100.00% <ø> (ø)
components/_util/motion.tsx 83.33% <83.33%> (-16.67%) ⬇️
components/alert/index.tsx 97.50% <96.15%> (-2.50%) ⬇️
... and 182 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a86b75...25cab2b. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Sep 17, 2020

This pull request introduces 1 alert when merging f6f35a0 into 4a86b75 - view on LGTM.com

new alerts:

  • 1 for Useless conditional

@afc163
Copy link
Member

afc163 commented Sep 17, 2020

image

icon 的颜色应该是灰色的。

@afc163
Copy link
Member

afc163 commented Sep 17, 2020 •
edited
Loading

ProForm 里用的是 tip：https://procomponents.ant.design/components/form#%E9%80%9A%E7%94%A8%E7%9A%84%E5%B1%9E%E6%80%A7

可以和 TechUI 的同学沟通一下，命名和结构保持一致。

@lgtm-com
Copy link

lgtm-com bot commented Sep 17, 2020

This pull request introduces 1 alert when merging 25cab2b into 7f7fe17 - view on LGTM.com

new alerts:

  • 1 for Useless conditional

@zombieJ zombieJ merged commit b08b759 into feature Sep 17, 2020
@zombieJ zombieJ deleted the form-tooltip branch September 17, 2020 09:11
@afc163 afc163 mentioned this pull request Sep 18, 2020
Closed
@afc163 afc163 mentioned this pull request Oct 10, 2020
Merged
@hsuanxyz hsuanxyz mentioned this pull request Oct 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afc163 afc163 afc163 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zombieJ @ant-design-bot @afc163