Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: AutoComplete warning when using placeholder and allowClear #26765

Merged
merged 1 commit into from
Sep 16, 2020
Merged

fix: AutoComplete warning when using placeholder and allowClear #26765

merged 1 commit into from
Sep 16, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Sep 16, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #26760

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix AutoComplete warning when using placeholder and allowClear.
🇨🇳 Chinese 修复 AutoComplete 使用 placeholder 和 allowClear 时抛出警告的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Sep 16, 2020 •
edited
Loading

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Sep 16, 2020 •
edited
Loading

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b340732:

Sandbox Source
antd reproduction template Configuration
antd reproduction template (forked) Issue #26760

@codecov
Copy link

codecov bot commented Sep 16, 2020 •
edited
Loading

Codecov Report

Merging #26765 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #26765   +/-   ##
=======================================
  Coverage   99.82%   99.82%           
=======================================
  Files         384      384           
  Lines        7371     7371           
  Branches     2009     2051   +42     
=======================================
  Hits         7358     7358           
  Misses         13       13
Impacted Files Coverage Δ
components/auto-complete/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0de1358...b340732. Read the comment docs.

@afc163 afc163 merged commit cefb877 into master Sep 16, 2020
@afc163 afc163 deleted the fix-auto-complete-warning branch September 16, 2020 03:51
@github-actions
Copy link
Contributor

Size Change: +5 B (0%)

Total Size: 876 kB

Filename Size Change
./dist/antd-with-locales.min.js 355 kB +2 B (0%)
./dist/antd.min.js 321 kB +3 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd.compact.min.css 66.4 kB 0 B
./dist/antd.dark.min.css 67.6 kB 0 B
./dist/antd.min.css 66.4 kB 0 B

compressed-size-action

@zombieJ zombieJ mentioned this pull request Sep 20, 2020
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rc-select warning when use placeholder and allowClear on AutoComplete element
2 participants
@afc163 @ant-design-bot