Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Align motion match #26628

Merged
merged 5 commits into from
Sep 8, 2020
Merged

fix: Align motion match #26628

merged 5 commits into from
Sep 8, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Sep 7, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

resolve #26519

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Motion related issue like Upload align flash and Form.Item with help ssr issue.
🇨🇳 Chinese 修复 Motion 相关问题例如 Upload 对齐闪烁与 Form.Item 配置 help 的 ssr 问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@zombieJ zombieJ requested a review from afc163 September 7, 2020 12:56
@zombieJ
Copy link
Member Author

zombieJ commented Sep 7, 2020

先过一下 Tooltip，如果没问题 antd 下个版本再批量把 rc-trigger 升级上来。

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Sep 7, 2020 •
edited
Loading

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Sep 7, 2020 •
edited
Loading

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2020 •
edited
Loading

Size Change: +444 B (0%)

Total Size: 876 kB

Filename Size Change
./dist/antd-with-locales.min.js 355 kB +56 B (0%)
./dist/antd.compact.min.css 66.4 kB +107 B (0%)
./dist/antd.dark.min.css 67.6 kB +120 B (0%)
./dist/antd.min.css 66.4 kB +105 B (0%)
./dist/antd.min.js 321 kB +56 B (0%)

compressed-size-action

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 7, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4ddc41b:

Sandbox Source
antd reproduction template Configuration
stupefied-framework-ko3j8 Issue #26519

afc163
afc163 reviewed Sep 7, 2020
View reviewed changes
package.json Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 7, 2020 •
edited
Loading

Codecov Report

Merging #26628 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #26628   +/-   ##
=======================================
  Coverage   99.82%   99.82%           
=======================================
  Files         384      384           
  Lines        7369     7369           
  Branches     2009     2060   +51     
=======================================
  Hits         7356     7356           
  Misses         13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1d216b...4ddc41b. Read the comment docs.

@zombieJ
Copy link
Member Author

zombieJ commented Sep 7, 2020

@afc163 pls help to check~

@zombieJ zombieJ merged commit c58135f into master Sep 8, 2020
@zombieJ zombieJ deleted the rc-tooltip branch September 8, 2020 03:34
@pr-triage pr-triage bot added the PR: merged label Sep 8, 2020
@afc163
Copy link
Member

afc163 commented Sep 8, 2020 •
edited
Loading

体积超标了，最好统一升级起来再发。

@afc163
Copy link
Member

afc163 commented Sep 8, 2020

test ci 也挂了。

@zombieJ
Copy link
Member Author

zombieJ commented Sep 8, 2020

先过一下 Tooltip，如果没问题 antd 下个版本再批量把 rc-trigger 升级上来。

不会太久的，这周发完后如果没有人报我下个 patch 统一升上来。免得一下子挂太多了。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afc163 afc163 afc163 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prop className did not match.
3 participants
@zombieJ @ant-design-bot @afc163