Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Invalid value for prop navigate on Link #26623

Merged
merged 1 commit into from
Sep 7, 2020
Merged

fix: Invalid value for prop navigate on Link #26623

merged 1 commit into from
Sep 7, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Sep 7, 2020 •
edited
Loading

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #26622

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Typography.Link warning Invalid value for prop navigate when using with react-router.
🇨🇳 Chinese 修复 Typography.Link 和 react-router 一起使用时抛出 Invalid value for prop navigate 的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Sep 7, 2020 •
edited
Loading

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Sep 7, 2020 •
edited
Loading

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2020

Size Change: +25 B (0%)

Total Size: 800 kB

Filename Size Change
./dist/antd-with-locales.min.js 317 kB +12 B (0%)
./dist/antd.min.js 283 kB +13 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd.compact.min.css 66.2 kB 0 B
./dist/antd.dark.min.css 67.5 kB 0 B
./dist/antd.min.css 66.3 kB 0 B

compressed-size-action

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 7, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 262fd73:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Sep 7, 2020 •
edited
Loading

Codecov Report

Merging #26623 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #26623   +/-   ##
=======================================
  Coverage   99.82%   99.82%           
=======================================
  Files         383      383           
  Lines        7348     7349    +1     
  Branches     2008     2008           
=======================================
+ Hits         7335     7336    +1     
  Misses         13       13
Impacted Files Coverage Δ
components/typography/Link.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9d3ee6...262fd73. Read the comment docs.

@afc163 afc163 merged commit e745e24 into master Sep 7, 2020
@afc163 afc163 deleted the fix-link-warning branch September 7, 2020 09:37
@pr-triage pr-triage bot added the PR: merged label Sep 7, 2020
knobo added a commit to knobo/ant-design that referenced this pull request Sep 14, 2020
@knobo
fix: Button as component for react-router Link
d6c4cc6 
React router passes `navigate` as prop to component in <Link to={to}
component={Component}>. This is already fixed for Typography.Link.
(ant-design#26623) This fixes `<Link to={to} component={Button}` />
@knobo knobo mentioned this pull request Sep 14, 2020
Merged
19 tasks
afc163 pushed a commit that referenced this pull request Sep 14, 2020
@knobo
fix: Button as component for react-router Link (#26740)
e09040f 
React router passes `navigate` as prop to component in <Link to={to}
component={Component}>. This is already fixed for Typography.Link.
(#26623) This fixes `<Link to={to} component={Button}` />
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warning: Invalid value for prop navigate on <a> tag
2 participants
@afc163 @ant-design-bot