-
-
Notifications
You must be signed in to change notification settings - Fork 50.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Controlled multiple files upload list sync #26612
Conversation
@@ -147,7 +147,7 @@ | |||
"rc-tree": "~3.9.0", | |||
"rc-tree-select": "~4.1.1", | |||
"rc-trigger": "~4.4.0", | |||
"rc-upload": "~3.3.0", | |||
"rc-upload": "~3.3.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upload 的逻辑有点蛋疼,多个份文件上传会分次触发 此外,过去 cc 下对于 fileList 的状态管理异步有些问题,反而导致运行没问题 😂 |
Size Change: +209 B (0%) Total Size: 800 kB
ℹ️ View Unchanged
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3b42561:
|
什么时候会有异步的 |
/rebase |
5764065
to
3b42561
Compare
主要原因是 这个 fix 做的事情就是把 |
OK,明白了,瞬间感觉逻辑好复杂呀😂 |
Codecov Report
@@ Coverage Diff @@
## master #26612 +/- ##
=======================================
Coverage 99.82% 99.82%
=======================================
Files 383 384 +1
Lines 7348 7368 +20
Branches 2008 2057 +49
=======================================
+ Hits 7335 7355 +20
Misses 13 13
Continue to review full report at Codecov.
|
主要就是 |
rc-upload的不发minor的话,已发布的4.6.x的 在没有当前这个PR的情况下是使用"rc-upload": "~3.3.1",是否有问题? |
|
@yoyo837 的意思是 rc-upload@3.3.1 + antd@4.6.3 会不会引发额外的问题。 |
不会有额外的了, |
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
resolve #26536
💡 Background and solution
📝 Changelog
☑️ Self Check before Merge