Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: form support messageVariables #26597

Merged
merged 11 commits into from
Sep 10, 2020
Merged

feat: form support messageVariables #26597

merged 11 commits into from
Sep 10, 2020

Conversation

hengkx
Copy link
Member

@hengkx hengkx commented Sep 5, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #26461

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English form item support messageVariables props
🇨🇳 Chinese form item 增加 messageVariables 属性

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Sep 5, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Sep 5, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 5, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 36c5f4c:

Sandbox Source
antd reproduction template Configuration

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2020

Size Change: +47 B (0%)

Total Size: 880 kB

Filename Size Change
./dist/antd-with-locales.min.js 357 kB +26 B (0%)
./dist/antd.min.js 323 kB +21 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd.compact.min.css 66.3 kB 0 B
./dist/antd.dark.min.css 67.6 kB 0 B
./dist/antd.min.css 66.3 kB 0 B

compressed-size-action

@codecov
Copy link

codecov bot commented Sep 5, 2020

Codecov Report

Merging #26597 into feature will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #26597   +/-   ##
========================================
  Coverage    99.82%   99.82%           
========================================
  Files          384      384           
  Lines         7380     7382    +2     
  Branches      2062     2063    +1     
========================================
+ Hits          7367     7369    +2     
  Misses          13       13           
Impacted Files Coverage Δ
components/form/FormItem.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca46793...36c5f4c. Read the comment docs.

@hengkx hengkx requested a review from zombieJ September 5, 2020 03:48
@zombieJ
Copy link
Member

zombieJ commented Sep 8, 2020

话说是不是直接开出这个 messageVariables 更好些?

@hengkx
Copy link
Member Author

hengkx commented Sep 8, 2020

话说是不是直接开出这个 messageVariables 更好些?

是不是 可以 多字段配置 显示的?

@hengkx hengkx changed the title feat: form support labelInMessage feat: form support messageVariables Sep 8, 2020
@zombieJ
Copy link
Member

zombieJ commented Sep 8, 2020

嗯。messageVariables 本身是为了拓展模板变量设计的,没在 antd 开是想看看有没有人真的有这个需求。有的话就开出来。不过这个属性名字也不一定就是 messageVariables。大家都可以看看。

cc @ant-design/ant-design-collaborators

@hengkx
Copy link
Member Author

hengkx commented Sep 8, 2020

看看 到底 叫什么,我这边 现在 是有这个 需求的 在某些情况下 没有label或者label不适用 又想 用 统一的 验证 规范 不想写额外的 代码

@hengkx
Copy link
Member Author

hengkx commented Sep 8, 2020

/rebase

@github-actions github-actions bot force-pushed the form-label-in-message branch from b211125 to b05bc45 Compare September 8, 2020 07:39
@zombieJ
Copy link
Member

zombieJ commented Sep 8, 2020

没人有反对那沿用 messageVariables 好了~~

@hengkx
Copy link
Member Author

hengkx commented Sep 8, 2020

看了下 check 好像是其他 模块导致的吧

@zombieJ
Copy link
Member

zombieJ commented Sep 9, 2020

我合一下 master: #26655

@hengkx
Copy link
Member Author

hengkx commented Sep 9, 2020

/rebase

@hengkx
Copy link
Member Author

hengkx commented Sep 9, 2020

bundle size 怎么经常挂

@zombieJ
Copy link
Member

zombieJ commented Sep 9, 2020

bundlesize 不用管,现在 master 有多个版本的 rc-trigger 来测一下新的 trigger 有没有问题,这周 patch 发完如果没有 bug report 我会统一升级上来。

@hengkx hengkx requested a review from zombieJ September 10, 2020 04:38
@zombieJ
Copy link
Member

zombieJ commented Sep 10, 2020

文档里 Form.Item 下方再写写用法

@zombieJ zombieJ merged commit faa534c into feature Sep 10, 2020
@zombieJ zombieJ deleted the form-label-in-message branch September 10, 2020 13:00
@afc163 afc163 mentioned this pull request Oct 10, 2020
@piyushk96
Copy link

Resolves #23329

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants