fix: Add missing properties to ShowUploadListInterface #26406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8eff00b:
|
Codecov Report
@@ Coverage Diff @@
## master #26406 +/- ##
=======================================
Coverage 99.75% 99.75%
=======================================
Files 383 383
Lines 7353 7353
Branches 2057 2057
=======================================
Hits 7335 7335
Misses 18 18
Continue to review full report at Codecov.
|
|
Can you fix this type declaration? ant-design/components/upload/Upload.tsx Line 227 in 093ba7a |
|
Sure thing |
bencallaway
force-pushed
the
update-upload-props-typescript-interface
branch
from
9aec4cb to
8eff00b
Compare
kerm1it
approved these changes
Aug 26, 2020
kerm1it
changed the title
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
close #26405
💡 Background and solution
With the addition of
downloadIconandremoveIconto theUploadcomponent'sshowUploadListprop, we need to update the relevant TS interfaceShowUploadListInterface. Adding these two as optional properties solves the issue.📝 Changelog
ShowUploadListInterfaceof Upload withremoveIconanddownloadIconproperties.ShowUploadListInterface类型添加removeIcon和downloadIcon属性声明。☑️ Self Check before Merge