Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Space preserve empty dom when children is null #26389

Merged
merged 2 commits into from
Aug 25, 2020
Merged

fix: Space preserve empty dom when children is null #26389

merged 2 commits into from
Aug 25, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Aug 25, 2020 •
edited by markdownify bot
Loading

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #26386

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Space preserve empty dom node when children contains empty node.
🇨🇳 Chinese 修复 Space 在 children 中包含空节点时会出现空 dom 的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/space/demo/debug.md

@zombieJ zombieJ requested a review from shaodahong August 25, 2020 08:09
@ant-design-bot
Copy link
Contributor

ant-design-bot commented Aug 25, 2020 •
edited
Loading

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Aug 25, 2020 •
edited
Loading

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 465762d:

Sandbox Source
antd reproduction template Configuration
unruffled-pond-7u75t Issue #26386

@github-actions
Copy link
Contributor

Size Change: +151 B (0%)

Total Size: 797 kB

Filename Size Change
./dist/antd-with-locales.min.js 316 kB +74 B (0%)
./dist/antd.min.js 282 kB +77 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd.compact.min.css 66.2 kB 0 B
./dist/antd.dark.min.css 67.4 kB 0 B
./dist/antd.min.css 66.2 kB 0 B

compressed-size-action

@codecov
Copy link

codecov bot commented Aug 25, 2020 •
edited
Loading

Codecov Report

Merging #26389 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #26389   +/-   ##
=======================================
  Coverage   99.70%   99.70%           
=======================================
  Files         382      383    +1     
  Lines        7344     7354   +10     
  Branches     2008     2057   +49     
=======================================
+ Hits         7322     7332   +10     
  Misses         22       22
Impacted Files Coverage Δ
components/space/Item.tsx 100.00% <100.00%> (ø)
components/space/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e25f032...465762d. Read the comment docs.

@zombieJ zombieJ merged commit 875e190 into master Aug 25, 2020
@zombieJ zombieJ deleted the fix-space branch August 25, 2020 08:43
@pr-triage pr-triage bot added the PR: merged label Aug 25, 2020
@ycjcl868 ycjcl868 mentioned this pull request Aug 31, 2020
Merged
@PeachScript PeachScript mentioned this pull request Jun 11, 2021
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaodahong shaodahong Awaiting requested review from shaodahong

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Space 存在空元素时 Dom 仍然会创建节点
2 participants
@zombieJ @ant-design-bot