Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(upload): props type declaration #26347

Merged
merged 3 commits into from
Aug 23, 2020
Merged

fix(upload): props type declaration #26347

merged 3 commits into from
Aug 23, 2020

Conversation

kerm1it
Copy link
Member

@kerm1it kerm1it commented Aug 23, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #26345

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Upload type declaration.
🇨🇳 Chinese 修复上传组件类型声明。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Aug 23, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Aug 23, 2020

@kerm1it kerm1it requested a review from afc163 August 23, 2020 12:55
@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 23, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 85dade2:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Aug 23, 2020

Codecov Report

Merging #26347 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #26347   +/-   ##
=======================================
  Coverage   99.57%   99.57%           
=======================================
  Files         382      382           
  Lines        7349     7349           
  Branches     2054     2054           
=======================================
  Hits         7318     7318           
  Misses         31       31           
Impacted Files Coverage Δ
components/upload/Upload.tsx 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71bdb0a...85dade2. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2020

Size Change: 0 B

Total Size: 797 kB

ℹ️ View Unchanged
Filename Size Change
./dist/antd-with-locales.min.js 315 kB 0 B
./dist/antd.compact.min.css 66.1 kB 0 B
./dist/antd.dark.min.css 67.4 kB 0 B
./dist/antd.min.css 66.1 kB 0 B
./dist/antd.min.js 282 kB 0 B

compressed-size-action

@afc163
Copy link
Member

afc163 commented Aug 23, 2020

来个用例。

@kerm1it
Copy link
Member Author

kerm1it commented Aug 23, 2020

来个用例。

这个应该没办法写测试,是 TS 类型声明的问题,测试和 demo 都是是用JS写的,测不出来这种问题。要规避的话以后的 demo 统一使用 TSX 应该就可以。

@afc163 afc163 merged commit d821558 into master Aug 23, 2020
@afc163 afc163 deleted the fix-26345 branch August 23, 2020 14:46
@pr-triage pr-triage bot added the PR: merged label Aug 23, 2020
@zombieJ zombieJ mentioned this pull request Aug 24, 2020
15 tasks
@kerm1it kerm1it mentioned this pull request Aug 24, 2020
1 task
@grmmph
Copy link

grmmph commented Aug 24, 2020

Hey.
4.6.0 actually creates another bug (took me the whole day to trace it to here)
I'm not quite sure what's the deal but it fucks up React.Context state management on onChange callback.

@kerm1it
Copy link
Member Author

kerm1it commented Aug 24, 2020

Hey.
4.6.0 actually creates another bug (took me the whole day to trace it to here)
I'm not quite sure what's the deal but it fucks up React.Context state management on onChange callback.

Can you provide a example?

@illusi03
Copy link

Hello,
Thanks for develop this theme, but i have a problem with version >= 4.6.x on deploye docker version mode.
If i try to build in local (It's NO Error).
But i try to deploy and build in docker container, Has error.
Downgrade on version <= 4.5.x is solved. But i want to uptodate in this package.
Thank you in advance.
Screenshot from 2020-08-25 14-07-42

@kerm1it
Copy link
Member Author

kerm1it commented Aug 25, 2020

Are you ensure antd is latest in docker container? Maybe the version of antd is locked in yarn.lock

@illusi03
Copy link

Awesome, the yarn.lock is also getting commit.
Ill try to remove that yarn.lock, Thanks for the answer.
Really apreciated bro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants