Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Progress type=circle success.percent #26307

Merged
merged 2 commits into from
Aug 20, 2020
Merged

fix: Progress type=circle success.percent #26307

merged 2 commits into from
Aug 20, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Aug 20, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #26299

💡 Background and solution

image

📝 Changelog

Language Changelog
🇺🇸 English Fix Progress success.percent not working when type="circle".
🇨🇳 Chinese 修复 Progress 当 type="circle"success.percent 不生效的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Aug 20, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Aug 20, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 20, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 338f072:

Sandbox Source
antd reproduction template Configuration

@github-actions
Copy link
Contributor

github-actions bot commented Aug 20, 2020

Size Change: +1.48 kB (0%)

Total Size: 808 kB

Filename Size Change
./dist/antd-with-locales.min.js 321 kB +772 B (0%)
./dist/antd.min.js 290 kB +704 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd.compact.min.css 65 kB 0 B
./dist/antd.dark.min.css 66.3 kB 0 B
./dist/antd.min.css 65 kB 0 B

compressed-size-action

@afc163 afc163 force-pushed the fix-progress-circle branch from 40bc2ea to d3ae6ae Compare August 20, 2020 08:21
@afc163
Copy link
Member Author

afc163 commented Aug 20, 2020

/rebase

@github-actions github-actions bot force-pushed the fix-progress-circle branch from d3ae6ae to 338f072 Compare August 20, 2020 08:48
@codecov
Copy link

codecov bot commented Aug 20, 2020

Codecov Report

Merging #26307 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #26307   +/-   ##
=======================================
  Coverage   99.56%   99.56%           
=======================================
  Files         374      374           
  Lines        7294     7299    +5     
  Branches     1988     2038   +50     
=======================================
+ Hits         7262     7267    +5     
  Misses         32       32           
Impacted Files Coverage Δ
components/progress/Circle.tsx 100.00% <100.00%> (ø)
components/progress/Line.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd2d50c...338f072. Read the comment docs.

@afc163 afc163 merged commit 9a84eb5 into master Aug 20, 2020
@afc163 afc163 deleted the fix-progress-circle branch August 20, 2020 09:15
@pr-triage pr-triage bot added the PR: merged label Aug 20, 2020
@zombieJ zombieJ mentioned this pull request Aug 22, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Progress does not support success percent for types 'circle' and 'dashboard'
2 participants