Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pagination font family #26230

Merged
merged 2 commits into from
Aug 17, 2020
Merged

fix: Pagination font family #26230

merged 2 commits into from
Aug 17, 2020

Conversation

albertms10
Copy link
Contributor

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#26175

💡 Background and solution

Inconsistency between font families in the Pagination component and the rest of UI elements.

📝 Changelog

Change @pagination-font-family variable value in default.less to @font-family.

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@albertms10 albertms10 changed the title Pagination font family fix: Pagination font family Aug 16, 2020
@ant-design-bot
Copy link
Contributor

ant-design-bot commented Aug 16, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Aug 16, 2020

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c32f0e6:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Aug 16, 2020

Codecov Report

Merging #26230 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #26230   +/-   ##
=======================================
  Coverage   99.54%   99.54%           
=======================================
  Files         373      373           
  Lines        7318     7318           
  Branches     2041     1993   -48     
=======================================
  Hits         7285     7285           
  Misses         33       33           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93c1614...c32f0e6. Read the comment docs.

@afc163 afc163 merged commit 65ba33e into ant-design:master Aug 17, 2020
@pr-triage pr-triage bot added the PR: merged label Aug 17, 2020
@albertms10 albertms10 deleted the pagination-font-family branch August 19, 2020 17:11
@zombieJ zombieJ mentioned this pull request Aug 22, 2020
1 task
@afc163 afc163 mentioned this pull request Sep 2, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants