Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: optimize cascader clear animation #26186

Merged
merged 8 commits into from
Aug 14, 2020
Merged

style: optimize cascader clear animation #26186

merged 8 commits into from
Aug 14, 2020

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Aug 13, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

点开下拉框，点击 clear 按钮，可以看到，面板会先进行清除动画，再进行关闭动画。动画效果不连贯。

📝 Changelog

Language Changelog
🇺🇸 English Optimize Cascader clear animation.
🇨🇳 Chinese 优化 Cascader 清除动画效果。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Aug 13, 2020 •
edited
Loading

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Aug 13, 2020 •
edited
Loading

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 13, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c305483:

Sandbox Source
antd reproduction template Configuration

@github-actions
Copy link
Contributor

github-actions bot commented Aug 13, 2020 •
edited
Loading

Size Change: +41 B (0%)

Total Size: 803 kB

Filename Size Change
./dist/antd-with-locales.min.js 319 kB +19 B (0%)
./dist/antd.min.js 288 kB +22 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd.compact.min.css 64.9 kB 0 B
./dist/antd.dark.min.css 66.1 kB 0 B
./dist/antd.min.css 64.9 kB 0 B

compressed-size-action

@xrkffgg xrkffgg requested a review from afc163 August 13, 2020 08:23
@codecov
Copy link

codecov bot commented Aug 13, 2020 •
edited
Loading

Codecov Report

Merging #26186 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #26186   +/-   ##
=======================================
  Coverage   99.54%   99.54%           
=======================================
  Files         373      373           
  Lines        7315     7319    +4     
  Branches     1992     2043   +51     
=======================================
+ Hits         7282     7286    +4     
  Misses         33       33
Impacted Files Coverage Δ
components/cascader/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c63268...c305483. Read the comment docs.

@xrkffgg
Copy link
Member Author

xrkffgg commented Aug 14, 2020

/rebase

afc163
afc163 reviewed Aug 14, 2020
View reviewed changes
components/cascader/index.tsx Outdated
this.handlePopupVisibleChange(false);
setTimeout(() => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个 setTimeout 要 clear 掉。

@xrkffgg xrkffgg requested a review from afc163 August 14, 2020 08:46
@afc163
Copy link
Member

afc163 commented Aug 14, 2020

test cov

@xrkffgg
Copy link
Member Author

xrkffgg commented Aug 14, 2020

Emmm，这次应该可以了~

@afc163 afc163 merged commit dc306a2 into master Aug 14, 2020
@afc163 afc163 deleted the opt-cascader branch August 14, 2020 09:53
@pr-triage pr-triage bot added the PR: merged label Aug 14, 2020
@xrkffgg xrkffgg mentioned this pull request Aug 17, 2020
Closed
@zombieJ zombieJ mentioned this pull request Aug 22, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afc163 afc163 Awaiting requested review from afc163

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xrkffgg @ant-design-bot @afc163