feat: Galician Locale #26015

barreeeiroo · 2020-08-04T12:16:47Z

🤔 This is a ...

🔗 Related issue link

Adds support for Galician language.

💡 Background and solution

This PR intends to add support for another language, Galician, spoken in the northwest of Spain.

📝 Changelog

Language	Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

Doc is updated/provided or not needed
Demo is updated/provided or not needed
TypeScript definition is updated/provided or not needed
Changelog is provided or not needed

todo · 2020-08-04T12:16:51Z

',

ant-design/components/locale/gl_ES.tsx

Lines 24 to 29 in 9a0e381

    
             selectAll: 'Seleccionar todo', 
        
             selectInvert: 'Invertir selección', 
        
             sortTitle: 'Ordenar', 
        
           }, 
        
           Modal: { 
        
             okText: 'Aceptar',

This comment was generated by todo based on a `todo` comment in `9a0e381` in #26015. cc @barreeeiroo.

ant-design-bot · 2020-08-04T12:19:51Z

ant-design-bot · 2020-08-04T12:19:52Z

afc163 · 2020-08-05T07:25:01Z

There is no rc-picker/lib/locale/gl_ES now.

barreeeiroo · 2020-08-05T19:11:01Z

@afc163 I know, I've also submitted a PR to their repo, so it can be used here

yoyo837 · 2020-08-06T02:39:31Z

@afc163 I know, I've also submitted a PR to their repo, so it can be used here

Is it submitted to the wrong place？

https://github.com/react-component/picker

barreeeiroo · 2020-08-06T10:43:36Z

@yoyo837 My bad, I did only the rc-pagination, not the rc-picker. Opened a PR now
react-component/picker#120

todo · 2020-08-06T10:45:56Z

',

ant-design/components/locale/gl_ES.tsx

Lines 23 to 28 in 677040c

    
             selectAll: 'Seleccionar todo', 
        
             selectInvert: 'Invertir selección', 
        
             sortTitle: 'Ordenar', 
        
           }, 
        
           Modal: { 
        
             okText: 'Aceptar',

This comment was generated by todo based on a `todo` comment in `677040c` in #26015. cc @barreeeiroo.

todo · 2020-08-06T10:48:24Z

',

ant-design/components/locale/gl_ES.tsx

Lines 23 to 28 in 38c438d

    
             selectAll: 'Seleccionar todo', 
        
             selectInvert: 'Invertir selección', 
        
             sortTitle: 'Ordenar' 
        
           }, 
        
           Modal: { 
        
             okText: 'Aceptar',

This comment was generated by todo based on a `todo` comment in `38c438d` in #26015. cc @barreeeiroo.

todo · 2020-08-06T10:49:05Z

',

ant-design/components/locale/gl_ES.tsx

Lines 23 to 28 in fcb6d05

    
             selectAll: 'Seleccionar todo', 
        
             selectInvert: 'Invertir selección', 
        
             sortTitle: 'Ordenar' 
        
           }, 
        
           Modal: { 
        
             okText: 'Aceptar',

This comment was generated by todo based on a `todo` comment in `fcb6d05` in #26015. cc @barreeeiroo.

afc163 · 2020-08-10T03:07:42Z

https://github.com/react-component/picker/releases/tag/v2.0.4

yoyo837 · 2020-08-10T03:23:22Z

Now you need to switch to the feature branch and dependence on the new version of rc-picker.

afc163 · 2020-08-12T04:06:43Z

ping @barreeeiroo

todo · 2020-08-13T11:41:31Z

',

ant-design/components/locale/gl_ES.tsx

Lines 23 to 28 in da0d581

    
             selectAll: 'Seleccionar todo', 
        
             selectInvert: 'Invertir selección', 
        
             sortTitle: 'Ordenar' 
        
           }, 
        
           Modal: { 
        
             okText: 'Aceptar',

This comment was generated by todo based on a `todo` comment in `da0d581` in #26015. cc @barreeeiroo.

todo · 2020-08-13T11:44:41Z

',

ant-design/components/locale/gl_ES.tsx

Lines 23 to 28 in e886be0

    
             selectAll: 'Seleccionar todo', 
        
             selectInvert: 'Invertir selección', 
        
             sortTitle: 'Ordenar' 
        
           }, 
        
           Modal: { 
        
             okText: 'Aceptar',

This comment was generated by todo based on a `todo` comment in `e886be0` in #26015. cc @barreeeiroo.

codesandbox-ci · 2020-08-13T11:56:26Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 638d71c:

Sandbox	Source
antd reproduction template	Configuration

todo · 2020-08-13T11:56:44Z

',

ant-design/components/locale/gl_ES.tsx

Lines 23 to 28 in cd00dc3

    
             selectAll: 'Seleccionar todo', 
        
             selectInvert: 'Invertir selección', 
        
             sortTitle: 'Ordenar', 
        
           }, 
        
           Modal: { 
        
             okText: 'Aceptar',

This comment was generated by todo based on a `todo` comment in `cd00dc3` in #26015. cc @barreeeiroo.

codecov · 2020-08-13T12:10:23Z

Codecov Report

Merging #26015 into feature will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           feature   #26015      +/-   ##
===========================================
- Coverage    99.52%   99.49%   -0.03%     
===========================================
  Files          378      377       -1     
  Lines         7339     7334       -5     
  Branches      2005     2046      +41     
===========================================
- Hits          7304     7297       -7     
- Misses          35       37       +2

Impacted Files	Coverage Δ
components/date-picker/locale/gl_ES.tsx	`0.00% <0.00%> (ø)`
components/locale/gl_ES.tsx	`0.00% <0.00%> (ø)`
components/time-picker/locale/gl_ES.tsx	`0.00% <0.00%> (ø)`
components/upload/Upload.tsx	`99.18% <0.00%> (-0.82%)`	⬇️
components/form/FormItem.tsx	`99.22% <0.00%> (-0.78%)`	⬇️
components/form/Form.tsx	`100.00% <0.00%> (ø)`
components/space/index.tsx	`100.00% <0.00%> (ø)`
components/form/context.tsx	`100.00% <0.00%> (ø)`
components/progress/Line.tsx	`100.00% <0.00%> (ø)`
components/progress/utils.ts	`100.00% <0.00%> (ø)`
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16962bb...638d71c. Read the comment docs.

barreeeiroo · 2020-08-13T14:05:25Z

@yoyo837 @afc163 fixed, and rebased the branch onto feature. I bumped the rc-picker to the minimum required version to work with the Galician locale.
All checks are passing.

yoyo837 · 2020-08-14T03:11:07Z

docs/react/i18n.en-US.md
docs/react/i18n.zh-CN.md

Please add docs for it.

Test case: /components/locale-provider/__tests__/index.test.js

afc163 · 2020-08-14T03:18:27Z

Please add test case.

todo · 2020-08-16T17:08:19Z

',

ant-design/components/locale/gl_ES.tsx

Lines 23 to 28 in eae905b

    
             selectAll: 'Seleccionar todo', 
        
             selectInvert: 'Invertir selección', 
        
             sortTitle: 'Ordenar', 
        
           }, 
        
           Modal: { 
        
             okText: 'Aceptar',

This comment was generated by todo based on a `todo` comment in `eae905b` in #26015. cc @barreeeiroo.

docs/react/i18n.zh-CN.md

yoyo837 · 2020-08-17T01:45:24Z

Pls run:

npm test -- -u

and push all changes.

afc163 · 2020-08-17T10:16:54Z

Please add test case like other locales.

todo · 2020-08-18T15:31:40Z

',

ant-design/components/locale/gl_ES.tsx

Lines 23 to 28 in 580b161

    
             selectAll: 'Seleccionar todo', 
        
             selectInvert: 'Invertir selección', 
        
             sortTitle: 'Ordenar', 
        
           }, 
        
           Modal: { 
        
             okText: 'Aceptar',

This comment was generated by todo based on a `todo` comment in `580b161` in #26015. cc @barreeeiroo.

barreeeiroo · 2020-08-18T15:45:52Z

@afc163 which test case are you talking about? I searched for es_ES tests, and only found one.

afc163 · 2020-08-19T02:52:21Z

Please rebase latest feature branch and run npm test -- -u to update test snapshot.
Please add a semantic commit or PR title.

zombieJ · 2020-08-20T06:41:37Z

/rebase

rc-pagination rc-picker

Co-authored-by: Amumu <yoyo837@hotmail.com>

barreeeiroo · 2020-08-20T09:07:31Z

@afc163 it should be ready now. I have changed the PR name and made a commit with a semantic name (which now passes the check), and run npm test -- -u updating the test snapshots. It now uses the latest feature commit:

zombieJ · 2020-08-20T09:39:37Z

@barreeeiroo, feature branch merged master yet. Pls rebase again. Thanks : )

yoyo837 · 2020-08-20T10:23:11Z

rebase, again :)
git clean -fdx or delete node_modules, package-lock.json or yarn.lock manually
npm test -- -u
push all changes

pr-triage bot added the PR: unreviewed label Aug 4, 2020

barreeeiroo changed the base branch from master to feature August 13, 2020 11:41

yoyo837 reviewed Aug 17, 2020

View reviewed changes

docs/react/i18n.zh-CN.md Outdated Show resolved Hide resolved

barreeeiroo changed the title ~~Galician Locale~~ feat: Galician Locale Aug 20, 2020

barreeeiroo and others added 5 commits August 20, 2020 10:52

feat: Create gl_ES

f7e3988

Bump dependencies

55ebcce

rc-pagination rc-picker

Add test case

61acd1e

Add documentation

36301bc

Co-authored-by: Amumu <yoyo837@hotmail.com>

Update test snapshots

385c96c

zombieJ added 2 commits August 21, 2020 09:23

merge feature

38153e7

fix snapshot

638d71c

zombieJ approved these changes Aug 21, 2020

View reviewed changes

pr-triage bot added PR: reviewed-approved and removed PR: unreviewed labels Aug 21, 2020

zombieJ merged commit f1a09fe into ant-design:feature Aug 21, 2020

pr-triage bot added PR: merged and removed PR: reviewed-approved labels Aug 21, 2020

zombieJ mentioned this pull request Aug 22, 2020

docs: 4.6.0 changelog #26342

Merged

1 task

yoyo837 mentioned this pull request Oct 5, 2022

Form add defaultValidateMessages.i18n language #23369

Open

69 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Galician Locale #26015

feat: Galician Locale #26015

barreeeiroo commented Aug 4, 2020

todo bot commented Aug 4, 2020

ant-design-bot commented Aug 4, 2020 •

edited

Loading

ant-design-bot commented Aug 4, 2020 •

edited

Loading

afc163 commented Aug 5, 2020

barreeeiroo commented Aug 5, 2020

yoyo837 commented Aug 6, 2020

barreeeiroo commented Aug 6, 2020

todo bot commented Aug 6, 2020

todo bot commented Aug 6, 2020

todo bot commented Aug 6, 2020

afc163 commented Aug 10, 2020

yoyo837 commented Aug 10, 2020

afc163 commented Aug 12, 2020

todo bot commented Aug 13, 2020

todo bot commented Aug 13, 2020

codesandbox-ci bot commented Aug 13, 2020 •

edited

Loading

todo bot commented Aug 13, 2020

codecov bot commented Aug 13, 2020 •

edited

Loading

barreeeiroo commented Aug 13, 2020

yoyo837 commented Aug 14, 2020 •

edited

Loading

afc163 commented Aug 14, 2020

todo bot commented Aug 16, 2020

yoyo837 commented Aug 17, 2020

afc163 commented Aug 17, 2020

todo bot commented Aug 18, 2020

barreeeiroo commented Aug 18, 2020

afc163 commented Aug 19, 2020

zombieJ commented Aug 20, 2020

barreeeiroo commented Aug 20, 2020

zombieJ commented Aug 20, 2020

yoyo837 commented Aug 20, 2020

feat: Galician Locale #26015

feat: Galician Locale #26015

Conversation

barreeeiroo commented Aug 4, 2020

🤔 This is a ...

🔗 Related issue link

💡 Background and solution

📝 Changelog

☑️ Self Check before Merge

todo bot commented Aug 4, 2020

',

This comment was generated by todo based on a todo comment in 9a0e381 in #26015. cc @barreeeiroo.

ant-design-bot commented Aug 4, 2020 • edited Loading

ant-design-bot commented Aug 4, 2020 • edited Loading

afc163 commented Aug 5, 2020

barreeeiroo commented Aug 5, 2020

yoyo837 commented Aug 6, 2020

barreeeiroo commented Aug 6, 2020

todo bot commented Aug 6, 2020

',

This comment was generated by todo based on a todo comment in 677040c in #26015. cc @barreeeiroo.

todo bot commented Aug 6, 2020

',

This comment was generated by todo based on a todo comment in 38c438d in #26015. cc @barreeeiroo.

todo bot commented Aug 6, 2020

',

This comment was generated by todo based on a todo comment in fcb6d05 in #26015. cc @barreeeiroo.

afc163 commented Aug 10, 2020

yoyo837 commented Aug 10, 2020

afc163 commented Aug 12, 2020

todo bot commented Aug 13, 2020

',

This comment was generated by todo based on a todo comment in da0d581 in #26015. cc @barreeeiroo.

todo bot commented Aug 13, 2020

',

This comment was generated by todo based on a todo comment in e886be0 in #26015. cc @barreeeiroo.

codesandbox-ci bot commented Aug 13, 2020 • edited Loading

todo bot commented Aug 13, 2020

',

This comment was generated by todo based on a todo comment in cd00dc3 in #26015. cc @barreeeiroo.

codecov bot commented Aug 13, 2020 • edited Loading

Codecov Report

barreeeiroo commented Aug 13, 2020

yoyo837 commented Aug 14, 2020 • edited Loading

afc163 commented Aug 14, 2020

todo bot commented Aug 16, 2020

',

This comment was generated by todo based on a todo comment in eae905b in #26015. cc @barreeeiroo.

yoyo837 commented Aug 17, 2020

afc163 commented Aug 17, 2020

todo bot commented Aug 18, 2020

',

This comment was generated by todo based on a todo comment in 580b161 in #26015. cc @barreeeiroo.

barreeeiroo commented Aug 18, 2020

afc163 commented Aug 19, 2020

zombieJ commented Aug 20, 2020

barreeeiroo commented Aug 20, 2020

zombieJ commented Aug 20, 2020

yoyo837 commented Aug 20, 2020

This comment was generated by todo based on a `todo` comment in `9a0e381` in #26015. cc @barreeeiroo.

ant-design-bot commented Aug 4, 2020 •

edited

Loading

ant-design-bot commented Aug 4, 2020 •

edited

Loading

This comment was generated by todo based on a `todo` comment in `677040c` in #26015. cc @barreeeiroo.

This comment was generated by todo based on a `todo` comment in `38c438d` in #26015. cc @barreeeiroo.

This comment was generated by todo based on a `todo` comment in `fcb6d05` in #26015. cc @barreeeiroo.

This comment was generated by todo based on a `todo` comment in `da0d581` in #26015. cc @barreeeiroo.

This comment was generated by todo based on a `todo` comment in `e886be0` in #26015. cc @barreeeiroo.

codesandbox-ci bot commented Aug 13, 2020 •

edited

Loading

This comment was generated by todo based on a `todo` comment in `cd00dc3` in #26015. cc @barreeeiroo.

codecov bot commented Aug 13, 2020 •

edited

Loading

yoyo837 commented Aug 14, 2020 •

edited

Loading

This comment was generated by todo based on a `todo` comment in `eae905b` in #26015. cc @barreeeiroo.

This comment was generated by todo based on a `todo` comment in `580b161` in #26015. cc @barreeeiroo.