Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: optimize select multiple disabled style #25980

Merged
merged 3 commits into from
Aug 4, 2020
Merged

style: optimize select multiple disabled style #25980

merged 3 commits into from
Aug 4, 2020

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Aug 3, 2020 •
edited by markdownify bot
Loading

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

  1. 增加了一个 多选 disabled 的 Demo。
  2. 增加鼠标禁用样式。
  3. 调整了禁用时多选 Tag 的边框颜色。感觉原来的在禁用背景色下基本看不见了。
View
Before image
After image

📝 Changelog

Language Changelog
🇺🇸 English Optimize the disabled style of Select multiple mode.
🇨🇳 Chinese 优化 Select 多选模式 disabled样式。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/select/demo/multiple.md

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Aug 3, 2020 •
edited
Loading

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Aug 3, 2020 •
edited
Loading

@xrkffgg
Copy link
Member Author

xrkffgg commented Aug 3, 2020

有木有 更好的 disabled 样式设计？
@zombieJ

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 3, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 35976f3:

Sandbox Source
antd reproduction template Configuration

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2020 •
edited
Loading

Size Change: +66 B (0%)

Total Size: 785 kB

Filename Size Change
./dist/antd-with-locales.min.js 311 kB -1 B
./dist/antd.compact.min.css 64.7 kB +18 B (0%)
./dist/antd.dark.min.css 66 kB +29 B (0%)
./dist/antd.min.css 64.7 kB +17 B (0%)
./dist/antd.min.js 279 kB +3 B (0%)

compressed-size-action

@zombieJ
Copy link
Member

zombieJ commented Aug 3, 2020

我让设计师看看~

@shangguanhongzhou
Copy link

我让设计师看看~

根据 antd 的色板来明确颜色色值
image

@xrkffgg
Copy link
Member Author

xrkffgg commented Aug 3, 2020

@shangguanhongzhou 暗黑主题的 描边 和 文本 说一下~

@xrkffgg xrkffgg changed the title style: optimize select multiple disabled style [WIP] style: optimize select multiple disabled style Aug 3, 2020
@pr-triage pr-triage bot removed the PR: unreviewed label Aug 3, 2020
@codecov
Copy link

codecov bot commented Aug 3, 2020 •
edited
Loading

Codecov Report

Merging #25980 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #25980   +/-   ##
=======================================
  Coverage   99.57%   99.57%           
=======================================
  Files         373      373           
  Lines        7313     7313           
  Branches     2034     2041    +7     
=======================================
  Hits         7282     7282           
  Misses         31       31

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5a7f03...35976f3. Read the comment docs.

@shangguanhongzhou
Copy link

@shangguanhongzhou 暗黑主题的 描边 和 文本 说一下~

image

@xrkffgg xrkffgg changed the title [WIP] style: optimize select multiple disabled style style: optimize select multiple disabled style Aug 4, 2020
@afc163 afc163 merged commit 87555eb into master Aug 4, 2020
@afc163 afc163 deleted the opt-select-dis branch August 4, 2020 03:56
@chenshuai2144 chenshuai2144 mentioned this pull request Aug 8, 2020
Merged
@xrkffgg xrkffgg mentioned this pull request Feb 5, 2021
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zombieJ zombieJ Awaiting requested review from zombieJ

@afc163 afc163 Awaiting requested review from afc163

@shangguanhongzhou shangguanhongzhou Awaiting requested review from shangguanhongzhou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xrkffgg @ant-design-bot @zombieJ @shangguanhongzhou @afc163