Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update rc-field-form@1.8.0 and support remove use array in Form.List #25638

Merged
merged 7 commits into from
Jul 15, 2020
Merged

feat: update rc-field-form@1.8.0 and support remove use array in Form.List #25638

merged 7 commits into from
Jul 15, 2020

Conversation

fireairforce
Copy link
Member

@fireairforce fireairforce commented Jul 15, 2020 •
edited
Loading

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

closes: #22298

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Support array in remove in the Form.List.
🇨🇳 Chinese Form.List 中的 remove 方法支持数组类型。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@fireairforce fireairforce requested a review from zombieJ July 15, 2020 09:57
@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 15, 2020 •
edited
Loading

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 15, 2020 •
edited
Loading

@zombieJ
Copy link
Member

zombieJ commented Jul 15, 2020

文档里单独提一个表格写一下他们的类型

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 15, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1ad2901:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Jul 15, 2020 •
edited
Loading

Codecov Report

Merging #25638 into feature will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #25638   +/-   ##
========================================
  Coverage    99.51%   99.51%           
========================================
  Files          373      373           
  Lines         7284     7284           
  Branches      2031     1984   -47     
========================================
  Hits          7249     7249           
  Misses          35       35
Impacted Files Coverage Δ
components/form/FormList.tsx 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01cec29...1ad2901. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Jul 15, 2020

/rebase

@zombieJ zombieJ merged commit b814270 into ant-design:feature Jul 15, 2020
@fireairforce fireairforce mentioned this pull request Jul 15, 2020
Closed
1 task
@fireairforce fireairforce deleted the form-delete branch July 15, 2020 16:13
@07akioni 07akioni mentioned this pull request Jul 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zombieJ zombieJ zombieJ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fireairforce @ant-design-bot @zombieJ @afc163