Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: increase @text-color contrast #25630

Merged
merged 2 commits into from
Jul 29, 2020
Merged

style: increase @text-color contrast #25630

merged 2 commits into from
Jul 29, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Jul 15, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#22343

💡 Background and solution

image

image

📝 Changelog

Language Changelog
🇺🇸 English Darker @text-color for WCAG 2.0 on contrast ratio
🇨🇳 Chinese 加深默认文本色彩以满足 WCAG 2.0 对比度的规范。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 15, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 15, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 15, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 53111e0:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Jul 15, 2020

Codecov Report

Merging #25630 into feature will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #25630   +/-   ##
========================================
  Coverage    99.52%   99.52%           
========================================
  Files          374      374           
  Lines         7292     7292           
  Branches      1988     1988           
========================================
  Hits          7257     7257           
  Misses          35       35           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af27b02...5cbe1ee. Read the comment docs.

@afc163
Copy link
Member Author

afc163 commented Jul 15, 2020

/rebase

@afc163
Copy link
Member Author

afc163 commented Jul 21, 2020

/rebase

@afc163
Copy link
Member Author

afc163 commented Jul 22, 2020

/rebase

@afc163
Copy link
Member Author

afc163 commented Jul 22, 2020

/rebase

@afc163
Copy link
Member Author

afc163 commented Jul 22, 2020

@shaodahong 怎么更新 UI snapshot?

@shaodahong
Copy link
Member

@shaodahong 怎么更新 UI snapshot?

Docker 启动后,npm run test-image -- -u

@afc163
Copy link
Member Author

afc163 commented Jul 27, 2020

/rebase

@afc163 afc163 mentioned this pull request Jul 27, 2020
5 tasks
@afc163 afc163 merged commit bf0cd10 into feature Jul 29, 2020
@afc163 afc163 deleted the style-text-color branch July 29, 2020 09:52
@xrkffgg xrkffgg mentioned this pull request Jul 31, 2020
17 tasks
@zombieJ zombieJ mentioned this pull request Aug 22, 2020
1 task
@zkwolf zkwolf mentioned this pull request Feb 6, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants