Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Notification align when set width #25168

Merged
merged 1 commit into from
Jun 23, 2020
Merged

fix: Notification align when set width #25168

merged 1 commit into from
Jun 23, 2020

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Jun 23, 2020 •
edited
Loading

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #25167

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix the issue that Notification modification width is not aligned with the edge of the screen.
🇨🇳 Chinese 修复 Notification 修改 width时没有相对屏幕边缘对齐的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/notification/demo/custom-style.md

@afc163
Copy link
Member

afc163 commented Jun 23, 2020

👍，changelog 可以写一下。

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jun 23, 2020 •
edited
Loading

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jun 23, 2020 •
edited
Loading

@xrkffgg
Copy link
Member Author

xrkffgg commented Jun 23, 2020

嗯，先关联下 issue~

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit eb4b9b6:

Sandbox Source
antd reproduction template Configuration
notification-issue-demo Issue #25167

@afc163
Copy link
Member

afc163 commented Jun 23, 2020

增加 Notification 设置 width时自动对齐。

修复 Notification 修改 width 有没有相对屏幕边缘对齐的问题。

@codecov
Copy link

codecov bot commented Jun 23, 2020 •
edited
Loading

Codecov Report

Merging #25168 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #25168   +/-   ##
=======================================
  Coverage   99.43%   99.43%           
=======================================
  Files         365      365           
  Lines        7302     7302           
  Branches     2034     2034           
=======================================
  Hits         7261     7261           
  Misses         41       41

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba992d2...eb4b9b6. Read the comment docs.

@afc163 afc163 merged commit 1575464 into master Jun 23, 2020
@afc163 afc163 deleted the fix-notification-width branch June 23, 2020 03:40
07akioni pushed a commit that referenced this pull request Jun 23, 2020
@xrkffgg @07akioni
fix: Notification align when set width (#25168)
fea7819
@chenshuai2144 chenshuai2144 mentioned this pull request Jun 28, 2020
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Notification auto align when set width
3 participants
@xrkffgg @afc163 @ant-design-bot