Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Reduce Button CSS size #24996

Merged
merged 2 commits into from
Jun 15, 2020
Merged

refactor: Reduce Button CSS size #24996

merged 2 commits into from
Jun 15, 2020

Conversation

07akioni
Copy link
Contributor

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

#24846

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@07akioni 07akioni requested a review from afc163 June 15, 2020 07:45
@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jun 15, 2020 •
edited
Loading

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jun 15, 2020 •
edited
Loading

xrkffgg
xrkffgg reviewed Jun 15, 2020
View reviewed changes
Copy link
Member

@xrkffgg xrkffgg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我记得你是在 feature 改过吧

@07akioni
Copy link
Contributor Author

我记得你是在 feature 改过吧

是这样，但是后面又有了 CSS 的改动要推到 master 上= =，样式还是会超，所以 cherry-picker 到 master 了。

@afc163 afc163 merged commit 520fbca into master Jun 15, 2020
@afc163 afc163 deleted the button-css-size branch June 15, 2020 08:00
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b66ae64:

Sandbox Source
antd reproduction template Configuration

@afc163 afc163 mentioned this pull request Jun 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrkffgg xrkffgg xrkffgg left review comments

@afc163 afc163 Awaiting requested review from afc163

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@07akioni @ant-design-bot @xrkffgg @afc163