Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Field id #24929

Merged
merged 1 commit into from
Jun 11, 2020
Merged

fix: Field id #24929

merged 1 commit into from
Jun 11, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jun 11, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

resolve #24888

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Form.Item still replace component id when id configured.
🇨🇳 Chinese 修复 Form.Item 在组件设置 id 时仍然会替换它的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jun 11, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jun 11, 2020

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c724e68:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Jun 11, 2020

Codecov Report

Merging #24929 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24929   +/-   ##
=======================================
  Coverage   99.34%   99.34%           
=======================================
  Files         365      365           
  Lines        7301     7303    +2     
  Branches     2042     2033    -9     
=======================================
+ Hits         7253     7255    +2     
  Misses         48       48           
Impacted Files Coverage Δ
components/form/FormItem.tsx 99.17% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2331ed0...c724e68. Read the comment docs.

@zombieJ zombieJ merged commit ada59b9 into master Jun 11, 2020
@zombieJ zombieJ deleted the fix-form branch June 11, 2020 14:26
@07akioni 07akioni mentioned this pull request Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form.Item下组件自定义设置的ID未生效
2 participants