Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: export CardInterface from Card resolves #24864 #24866

Merged
merged 1 commit into from
Jun 9, 2020
Merged

fix: export CardInterface from Card resolves #24864 #24866

merged 1 commit into from
Jun 9, 2020

Conversation

THPubs
Copy link
Contributor

@THPubs THPubs commented Jun 9, 2020 •
edited by zombieJ
Loading

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#24864

💡 Background and solution

The CardInterface is not exported from the Card so Typescript cannot determine the shape of CardInterface.

This fix exports the CardInterface.

📝 Changelog

  • Exports the CardInterface from components/card/index.tsx

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jun 9, 2020 •
edited
Loading

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jun 9, 2020 •
edited
Loading

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 9, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c070eda:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Jun 9, 2020 •
edited
Loading

Codecov Report

Merging #24866 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24866   +/-   ##
=======================================
  Coverage   99.31%   99.31%           
=======================================
  Files         365      365           
  Lines        7299     7299           
  Branches     2041     1991   -50     
=======================================
  Hits         7249     7249           
  Misses         50       50
Impacted Files Coverage Δ
components/card/index.tsx 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84381e3...c070eda. Read the comment docs.

@zombieJ zombieJ merged commit c72c773 into ant-design:master Jun 9, 2020
@07akioni 07akioni mentioned this pull request Jun 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@THPubs @ant-design-bot @zombieJ