Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: badge offset in rtl #24724

Merged
merged 5 commits into from
Jun 6, 2020
Merged

fix: badge offset in rtl #24724

merged 5 commits into from
Jun 6, 2020

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Jun 4, 2020 •
edited by markdownify bot
Loading

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #24441

💡 Background and solution

#24441 (comment)

📝 Changelog

Language Changelog
🇺🇸 English Fix Badge offset in RTL.
🇨🇳 Chinese 修复 Badge RTL 模式位置偏移量设置。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/badge/demo/offset.md

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jun 4, 2020 •
edited
Loading

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jun 4, 2020 •
edited
Loading

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 4, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a024311:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Jun 4, 2020 •
edited
Loading

Codecov Report

Merging #24724 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24724   +/-   ##
=======================================
  Coverage   99.21%   99.21%           
=======================================
  Files         365      365           
  Lines        7288     7292    +4     
  Branches     2035     1988   -47     
=======================================
+ Hits         7231     7235    +4     
  Misses         57       57
Impacted Files Coverage Δ
components/badge/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e361b30...a024311. Read the comment docs.

@xrkffgg xrkffgg changed the title fix: badge offset in rtl [WIP] fix: badge offset in rtl Jun 4, 2020
@pr-triage pr-triage bot removed the PR: unreviewed label Jun 4, 2020
@xrkffgg xrkffgg changed the title [WIP] fix: badge offset in rtl fix: badge offset in rtl Jun 4, 2020
@xrkffgg xrkffgg requested review from afc163 and zombieJ June 4, 2020 08:21
@zombieJ
Copy link
Member

zombieJ commented Jun 4, 2020

感觉还需要在调研一下，在 css 里 RTL 用 translate 也是按照原来的左右。改成相反它就意味着是距离起始点的偏移了。

@xrkffgg xrkffgg requested a review from saeedrahimi June 4, 2020 09:48
@xrkffgg
Copy link
Member Author

xrkffgg commented Jun 4, 2020

@israelKusayev @saeedrahimi

Please help to review. ❤
And if this is expected in RTL?

@ant-design ant-design deleted a comment from xrkffgg Jun 4, 2020
@xrkffgg xrkffgg changed the title fix: badge offset in rtl [WIP] fix: badge offset in rtl Jun 4, 2020
@pr-triage pr-triage bot removed the PR: unreviewed label Jun 4, 2020
@israelKusayev
Copy link
Contributor

LGTM

@xrkffgg xrkffgg changed the title [WIP] fix: badge offset in rtl fix: badge offset in rtl Jun 6, 2020
@xrkffgg
Copy link
Member Author

xrkffgg commented Jun 6, 2020

/rebase

@github-actions github-actions bot force-pushed the fix-badge-offset-rtl branch from 617f8f6 to 245276c Compare June 6, 2020 03:06
@xrkffgg xrkffgg mentioned this pull request Jun 6, 2020
Merged
@afc163 afc163 merged commit 955fa52 into master Jun 6, 2020
@afc163 afc163 deleted the fix-badge-offset-rtl branch June 6, 2020 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afc163 afc163 Awaiting requested review from afc163

@zombieJ zombieJ Awaiting requested review from zombieJ

@saeedrahimi saeedrahimi Awaiting requested review from saeedrahimi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

offset xy in RTL
5 participants
@xrkffgg @ant-design-bot @zombieJ @israelKusayev @afc163