-
-
Notifications
You must be signed in to change notification settings - Fork 50.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: #24670 allow user customize table font size with less variable #24714
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit cdf0733:
|
@@ -574,6 +574,9 @@ | |||
@table-footer-bg: @background-color-light; | |||
@table-footer-color: @heading-color; | |||
@table-header-bg-sm: @table-header-bg; | |||
@table-font-size: @font-size-base; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
关注下 紧凑模式 themes/compact.less 是不是需要调整。
@table-font-size-md @table-font-size-sm 都用 base 吗?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我看你的 PR 的 Background and solution 写的是3个尺寸呀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我觉得我们只是提供一个让用户能自定义的方式,如果直接改的话会影响已有的样式
Codecov Report
@@ Coverage Diff @@
## master #24714 +/- ##
=======================================
Coverage 99.21% 99.21%
=======================================
Files 365 365
Lines 7278 7278
Branches 2031 2031
=======================================
Hits 7221 7221
Misses 57 57 Continue to review full report at Codecov.
|
[中文版模板 / Chinese template]
close #24670
🤔 This is a ...
🔗 Related issue link
#24670
💡 Background and solution
@table-font-size
,@table-font-size-md
,@table-font-size-sm
@font-size-base
by defaultDemo on local (set
font-size
to 16px, 14px, 12px temporary)📝 Changelog
@table-font-size
,@table-font-size-md
and@table-font-size-sm
to customize the size of Table text.@table-font-size
,@table-font-size-md
和@table-font-size-sm
,用于自定义 Table 文字大小。☑️ Self Check before Merge