Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Password value still exists after blur it #24535

Merged
merged 1 commit into from
May 28, 2020
Merged

Conversation

afc163
Copy link
Member

@afc163 afc163 commented May 28, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #24526

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Input.Password still show value attribute in DOM after blur it.
🇨🇳 Chinese 修复 Input.Password 一个明文显示 value 的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@ant-design-bot
Copy link
Contributor

ant-design-bot commented May 28, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented May 28, 2020

@codecov
Copy link

codecov bot commented May 28, 2020

Codecov Report

Merging #24535 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24535   +/-   ##
=======================================
  Coverage   99.12%   99.12%           
=======================================
  Files         363      363           
  Lines        7228     7228           
  Branches     1969     2008   +39     
=======================================
  Hits         7165     7165           
  Misses         63       63           
Impacted Files Coverage Δ
components/input/Input.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6773020...190912e. Read the comment docs.

@afc163 afc163 merged commit 4be9535 into master May 28, 2020
@afc163 afc163 deleted the fix-input-password-value branch May 28, 2020 06:49
@zombieJ zombieJ mentioned this pull request May 31, 2020
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Input password still has value prop in DOM
2 participants