fix: enhance upload custom progress bar #24339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix progress bar `type` could be overridden - update demo
|
|
17 tasks
xrkffgg
reviewed
May 21, 2020
| @@ -177,7 +177,7 @@ export default class UploadList extends React.Component<UploadListProps, any> { | |||
| // show loading icon if upload progress listener is disabled | |||
| const loadingProgress = | |||
| 'percent' in file ? ( | |||
| <Progress type="line" {...progressProps} percent={file.percent} /> | |||
| <Progress {...progressProps} type="line" percent={file.percent} /> | |||
There was a problem hiding this comment.
progressProps 的 ts 定义也可以把 type 和 percent 都 Omit 掉。
There was a problem hiding this comment.
progressProps 的 ts 定义也可以把 type 和 percent 都 Omit 掉。
already done in
xrkffgg
reviewed
May 21, 2020
xrkffgg
approved these changes
May 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
typecould be overridden📝 Changelog
☑️ Self Check before Merge
View rendered components/upload/demo/customize-progress-bar.md