Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: support custom cell ellipsis tooltip #24056

Merged
merged 9 commits into from
May 12, 2020

Conversation

lijinke666
Copy link
Contributor

@lijinke666 lijinke666 commented May 11, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

react-component/table#474

💡 Background and solution

image

📝 Changelog

Language Changelog
🇺🇸 English Custom cell ellipsis tooltip
🇨🇳 Chinese 自定义单元格省略后的提示

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered .github/PULL_REQUEST_TEMPLATE.md
View rendered .github/PULL_REQUEST_TEMPLATE/pr_cn.md
View rendered components/table/demo/ellipsis-custom-tooltip.md
View rendered components/table/index.en-US.md
View rendered components/table/index.zh-CN.md

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@ant-design-bot
Copy link
Contributor

ant-design-bot commented May 11, 2020

@lijinke666
Copy link
Contributor Author

lijinke666 commented May 11, 2020

本地测试跑不过, 没有动到这块呀?大佬们能否解答一下?

image

image

@hengkx
Copy link
Member

hengkx commented May 11, 2020

重新安装 删除lock也不行吗? 这个 好像是我改的 ,昨天提pr是全部可以通过的

@lijinke666
Copy link
Contributor Author

重新安装 删除lock也不行吗? 这个 好像是我改的 ,昨天提pr是全部可以通过的

我再试试

@lijinke666
Copy link
Contributor Author

删除lock重新安装 ok 了

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 12, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ca840e2:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented May 12, 2020

Codecov Report

Merging #24056 into feature will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #24056   +/-   ##
========================================
  Coverage    98.74%   98.74%           
========================================
  Files          365      365           
  Lines         7318     7318           
  Branches      1984     2034   +50     
========================================
  Hits          7226     7226           
  Misses          92       92           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d766472...ca840e2. Read the comment docs.

@lijinke666
Copy link
Contributor Author

@hengkx 可以了

@afc163 afc163 merged commit f250b2f into ant-design:feature May 12, 2020
@zombieJ zombieJ mentioned this pull request May 31, 2020
13 tasks
@zhaoy0221
Copy link

这样设置showTitle为false,自定义render Tooltip会出现一个问题就是可能某一行的数据并没有省略,内容可以显示的下的情况也会出现Tooltip,有没有优化方案呢?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants